Skip to content

Fix fmt script error - #54

Open
KurbyDoo wants to merge 1 commit into
mainfrom
fix-fmt-command-error
Open

Fix fmt script error#54
KurbyDoo wants to merge 1 commit into
mainfrom
fix-fmt-command-error

Conversation

@KurbyDoo

Copy link
Copy Markdown
Member

Summary

Script was mishandling empty values

Validation

  • scripts/quality-check.sh passes locally
  • Appropriate /test commands were run and are passing (e.g. /test gpu)
  • Unit tests were added / e2e tests were added where applicable
  • [] Manual testing, if applicable (describe further):

Checklist

  • The change is focused and easy to review.
  • Tests were added or updated for behaviour changes.
  • No secrets, generated files, or files that only make sense on my machine are included.
  • Relevant documentation is updated.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32556882173

Coverage remained the same at 96.765%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 340
Covered Lines: 329
Line Coverage: 96.76%
Coverage Strength: 0.97 hits per line

💛 - Coveralls

@yh-cyber yh-cyber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yh-cyber

Copy link
Copy Markdown
Contributor

tried it on my end and it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants