Repository navigation
fix(demo): provide Link URL resolvers for demo stacks - #758
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: efbbc77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying stackflow-demo with
|
| Latest commit: |
b888389
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0da7ce91.stackflow-demo.pages.dev |
| Branch Preview URL: | https://fix-demo-link-url-resolver.stackflow-demo.pages.dev |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🔵 In progress View logs |
stackflow-docs | efbbc77 | Oct 06 2026, 08:31 AM |
ENvironmentSet
marked this pull request as ready for review
October 6, 2026 08:30
ENvironmentSet
enabled auto-merge (squash)
October 6, 2026 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening an article in the demo rendered recommendation cards without a
LinkUrlResolverProvider, causing@stackflow/link3 to throw and unmount the app. The demo also still depended on history-sync 1.x, which does not expose the required resolver.Use history-sync 2.1 and provide the same plugin instance's URL resolver to the standalone demo. Wrap the exported documentation demo with its own resolver and use memory history so embedded navigation preserves the documentation page URL. Update the JSX build entry and Yarn dependency metadata.
Validation:
yarn workspace @stackflow/demo typecheckandbuildpassed.yarn workspace @stackflow/docs buildpassed, including generation of all 156 static pages. Wrangler emitted a sandbox log-file permission warning; the build exited successfully.git diff --check, and an immutable Yarn install passed.The temporary browser fixture was removed after validation. No published library API changes are included.