Skip to content

fix(demo): provide Link URL resolvers for demo stacks - #758

Merged
ENvironmentSet merged 3 commits into
mainfrom
fix/demo-link-url-resolver
Oct 6, 2026
Merged

ENvironmentSet merged 3 commits into
mainfrom
fix/demo-link-url-resolver

Conversation

@ENvironmentSet

Copy link
Copy Markdown
Collaborator

Opening an article in the demo rendered recommendation cards without a LinkUrlResolverProvider, causing @stackflow/link 3 to throw and unmount the app. The demo also still depended on history-sync 1.x, which does not expose the required resolver.

Use history-sync 2.1 and provide the same plugin instance's URL resolver to the standalone demo. Wrap the exported documentation demo with its own resolver and use memory history so embedded navigation preserves the documentation page URL. Update the JSX build entry and Yarn dependency metadata.

Validation:

  • yarn workspace @stackflow/demo typecheck and build passed.
  • yarn workspace @stackflow/docs build passed, including generation of all 156 static pages. Wrangler emitted a sandbox log-file permission warning; the build exited successfully.
  • Focused Biome checks, git diff --check, and an immutable Yarn install passed.
  • Browser checks passed for article entry, recommendation Link navigation, and back navigation in both the standalone demo and a StrictMode fixture using the exported embedded Stack. The standalone URL changed correctly, the embedded host URL stayed unchanged, and no page exceptions were recorded.

The temporary browser fixture was removed after validation. No published library API changes are included.

@changeset-bot

changeset-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: efbbc77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: daangn/stackflow/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 68f4dd25-eb4b-4cd4-8970-fd0c0548146c
📥 Commits

Reviewing files that changed from the base of the PR and between 8c6f6ac and efbbc77.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (7)
  • .changeset/demo-link-resolver.md
  • .pnp.cjs
  • demo/esbuild.config.js
  • demo/package.json
  • demo/src/App.tsx
  • demo/src/stackflow/Stack.tsx
  • demo/src/stackflow/stackflow.docs.tsx
 _____________________________________________
< Assembling the Avengers to fight your bugs. >
 ---------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Deploying stackflow-demo with  Cloudflare Pages  Cloudflare Pages

Latest commit: b888389
Status: ✅  Deploy successful!
Preview URL: https://0da7ce91.stackflow-demo.pages.dev
Branch Preview URL: https://fix-demo-link-url-resolver.stackflow-demo.pages.dev

View logs

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
🔵 In progress
View logs
stackflow-docs efbbc77 Oct 06 2026, 08:31 AM

@ENvironmentSet
ENvironmentSet marked this pull request as ready for review October 6, 2026 08:30
@ENvironmentSet
ENvironmentSet enabled auto-merge (squash) October 6, 2026 08:30
@ENvironmentSet
ENvironmentSet merged commit b886837 into main Oct 6, 2026
8 of 10 checks passed
@ENvironmentSet
ENvironmentSet deleted the fix/demo-link-url-resolver branch October 6, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant