Repository navigation
BDSP AutoStory: fix the Ubuntu gcc and Windows clang build errors - #115
Merged
Merged
Conversation
Include <cmath> for std::lround in the AutoStory tests, count the red pixels with an if instead of adding a bool (gcc -Wint-in-bool-context), and take the MoveOnlyFunction test file from common/move-only-function, which drops the noexcept move-assignment static assertion that fails on Windows clang. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…-context The Ubuntu gcc error was on the area check two lines further down, not on the counter: a product used as a condition. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
marked this pull request as ready for review
November 1, 2026 05:50
dayfine
added a commit
that referenced
this pull request
Nov 1, 2026
PokemonBDSP_AutoStory_Tests.cpp: every walk-table entry takes #110's costs (the ones the program plans with) on #111's re-derived grids; the westward Route 202-checkpoint walk starts east of the Lab's sign (#111); "Save spot to Jubilife" from {save_spot} (#110) replaces the trailing known-failing "Save spots to Jubilife" check. RouteRecords.cpp: #110's Oreburgh City and Floaroma grids and start tiles, #111's traceable Jubilife and Route 203 records. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
bdsp/event-sandgem-center(fork PR of the BDSP lab branch); the diff shows only this change.The BDSP branch fails fork CI on three compile errors that lab/tooling does not have: Ubuntu gcc rejects
std::lroundinPokemonBDSP_AutoStory_Tests.cppwithout<cmath>, gcc warns-Wint-in-bool-contexton the bool added to a counter inPokemonBDSP_AutoStoryTools.cpp, and Windows clang fails thestd::is_nothrow_move_assignablestatic assertion inCommon/Cpp/MoveOnlyFunction_Tests.cpp. This adds the include, counts with anif, and takes the test file verbatim fromcommon/move-only-function(fork PR #72). Compile-only fixes, no behavior change.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E