Skip to content

BDSP AutoStory: fix the Ubuntu gcc and Windows clang build errors #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dayfine merged 2 commits into from
Nov 1, 2026
Merged

BDSP AutoStory: fix the Ubuntu gcc and Windows clang build errors #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f4c4e3
BDSP AutoStory: fix the Ubuntu gcc and Windows clang build errors
dayfine Nov 1, 2026
4e2ffa8
BDSP AutoStory: compare the badge area to zero, for gcc -Wint-in-bool…
dayfine Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Common/Cpp/MoveOnlyFunction_Tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ namespace{
static_assert(!std::is_copy_constructible_v<MoveOnlyFunction<void()>>);
static_assert(!std::is_copy_assignable_v<MoveOnlyFunction<void()>>);
static_assert(std::is_nothrow_move_constructible_v<MoveOnlyFunction<void()>>);
static_assert(std::is_nothrow_move_assignable_v<MoveOnlyFunction<void()>>);



Expand Down
7 changes: 5 additions & 2 deletions SerialPrograms/Source/PokemonBDSP/Programs/AutoStory/PokemonBDSP_AutoStoryTools.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "PokemonBDSP/Inference/PokemonBDSP_TransitionWatchers.h"

Check failure on line 1 in SerialPrograms/Source/PokemonBDSP/Programs/AutoStory/PokemonBDSP_AutoStoryTools.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health 

<file>: file_lines=2295, limit=1000, allowed 2292
#include "CommonFramework/GlobalAutoPaths.h"
#include "Common/Cpp/Filesystem/Filesystem.h"
#include "Common/Cpp/PrettyPrint.h"
Expand Down Expand Up @@ -1449,7 +1449,7 @@
// return dark < names.width() * names.height() * 0.001;
// }

size_t bag_clear_tab_count(const ImageViewRGB32& frame){

Check failure on line 1452 in SerialPrograms/Source/PokemonBDSP/Programs/AutoStory/PokemonBDSP_AutoStoryTools.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health 

PokemonAutomation::NintendoSwitch::PokemonBDSP::bag_clear_tab_count( const ImageViewRGB32 & frame): function_lines=54, limit=50, allowed 51
if (!frame || bag_pocket_position(frame) == 0){
return 0;
}
Expand Down Expand Up @@ -1483,10 +1483,13 @@
for (size_t bx = 0; bx < badge.width(); bx++){
const uint32_t pixel = badge.pixel(bx, y);
int rr = (pixel >> 16) & 255, gg = (pixel >> 8) & 255, bb = pixel & 255;
red += rr > 150 && rr > gg + 60 && rr > bb + 60;
if (rr > 150 && rr > gg + 60 && rr > bb + 60){
red++;
}
}
}
if (badge.width() * badge.height() && (double)red / (badge.width() * badge.height()) > .45){
const size_t badge_area = badge.width() * badge.height();
if (badge_area > 0 && (double)red / badge_area > .45){
continue;
}
const ImageFloatBox box{x, .06, .038, .072};
Expand Down
1 change: 1 addition & 0 deletions SerialPrograms/Source/PokemonBDSP/Programs/AutoStory/PokemonBDSP_AutoStory_Tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
/* BDSP AutoStory Tests

Check failure on line 1 in SerialPrograms/Source/PokemonBDSP/Programs/AutoStory/PokemonBDSP_AutoStory_Tests.cpp

View workflow job for this annotation

GitHub Actions / code-health

Code health 

<file>: file_lines=2036, limit=1000, allowed 2035
*
* From: https://github.com/PokemonAutomation/
*
*/

#include <cmath>
#include <functional>
#include "Common/Cpp/Exceptions.h"
#include "Common/Cpp/Filesystem/Filesystem.h"
Expand Down
Loading