Skip to content

BDSP AutoStory: the story table's named events as shared story steps - #173

Closed
dayfine wants to merge 14 commits into
bdsp/autostory-v4-seg01from
bdsp/shared-steps
Closed

dayfine wants to merge 14 commits into
bdsp/autostory-v4-seg01from
bdsp/shared-steps

Conversation

@dayfine

@dayfine dayfine commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Depends on #175 (base bdsp/autostory-v4-seg01), which depends on #128

BDSP AutoStory's story table swaps its hand-written named events for the shared story steps (ROUTE, LEGS, STEP, TALK, MASH, BATTLE, HEAL), one checkpoint per commit, earliest first. Events_*.cpp goes from 1,487 lines (seg01) to 725.

  • 00.01, 00.04: nothing to convert. The Azure Flute, the catching tutorial and the catch stay named (BDSP-only scripts).
  • 00.02: the Starly battle is a BATTLE step (variant "starter"); the walk out of the lake is a MASH scene. The briefcase and the starter choice stay named (BDSP-only menus).
  • 00.03: Rowan's Pokedex is a MASH scene ending at Rowan in the lab.
  • 00.04c, 00.04d: stay named. The Mart lady's walk checks itself on two signs and looks for her up to three times; the stairs into Jubilife walk west until Dawn's scene starts, which in BDSP is not on Diamond's trigger above the steps (see 00.05).
  • 00.05: starts from a save at (48, 62), below Jubilife's steps against the wall east of them, where 00.04d's Dawn scene now ends; up_the_steps is a LEGS step of the old taps (a tile west, two north) to (47, 60). Barry's Town Map is a TALK west and a MASH scene with A. 00.05b's wandering clowns stay named.
  • 01.01: starts on the street where 00.05c ends; a route onto Route 203, a step onto Barry's coord event (5, 17..20), his battle.
  • 01.02: down the trigger's column to (5, 20), then planned on Route 203, the Gate and Oreburgh with the decomp's coord events; the Gate's trainers one route each. Events_Route203.cpp is gone.
  • 01.03: planned on Oreburgh's map and the mine's coal room (now a room world). To the fence below the Center and north (one known tile), a tap west below the Center's door (47, 20), Barry's talk; a route round the Hiker's patch to above the mine's warp tiles (44..48, 59), now doors in the map generator (WARP_DOORS); the entrance hall (a new map from the decomp, narc_0313) on 19 counted taps each way plus a step onto its warp row (no hold a wild battle could end); down the coal room's corridor to the boulder, a route below Roark, his talk and scene; back out, north to the mine's sign, a route to below the Center's door and HEAL. TALK now waits 8 s for a line (Roark's comes after a camera zoom, r98).
  • 01.04: stays named (gym_until_roark_beaten). After a loss it walks back from the Center keeping the battles' experience; a reload of the row's save would take that away. It now starts outside the Center, where 01.03's heal leaves us; out_of_the_center is gone.
  • 01.09: Rock Smash stays named (its Yes/No box).
  • 01.11: 8 taps west along row 29, north until the old woman stops us, her talk; a tap west, the old man's talk. Events_Route204.cpp keeps only Rock Smash.

Console checks needed

  • 00.02: after the Starly battle, the scene settles on the Lakefront at (17, 14) or (17, 15) facing south, and no 5 s still screen ends it early (it used to be 60 s of B).
  • 00.03: the scene's B answers the nickname question No and closes the Pokedex lines; it ends in the lab at Rowan (rowan_talk) facing north.
  • 00.05 (assumed from the old event and the map): Dawn's scene and 00.05's save are at (48, 62); a tap west and two north end on (47, 60), and the route to the Center (52, 41) plans from there.
  • 00.05: the walk up the School's door column ends beside Barry; a turn west and A starts his talk; A closes "You obtained a Town Map!".
  • 01.01: a save on the street at (58, 22). The route ends at Route 203 (4, 18) without touching column 5; the step onto (5, 18) starts Barry; after the battle we still stand on (5, 17..20).
  • 01.02: the walk south stops at (5, 20); the route reaches Route 203 (55, 9) and the tap east shows the Gate's banner at (4, 22) or (5, 22); the step onto (7, 22) starts the Hiker, and the scene closes the Hidden Moves card; Curtis stops the route to (20, 22) and Diana the one to (27, 22); the tap east from (27, 22) shows Oreburgh's banner at (2, 13) or (3, 13); the step onto (10, 13) starts the welcome man; the scene does not settle between his walk and Barry's lines.
  • 01.03 (assumed): the welcome scene leaves us on (43..45, 21..22), not Diamond's (23, 23) by the Gym; east then north to the walls ends on (48, 21).
  • 01.03 (assumed): the Center's door is the decomp's column 47, not 46 (the map's doorstep (46, 21) is the Gym's door column plus 01.04's 20 taps); Barry stands in it, so A from (47, 21) facing north opens his talk. If not, his talk is the first step to fail.
  • 01.03 (from the decomp's warps): south from (46, 58) onto (46, 59) enters the mine and lands on the hall's (12, 1); 19 taps south end on (12, 20) (we land on the warp tile, not a row below it) and the step south goes down to the coal room; there column 15 south stops at the boulder (15, 10), on (15, 9).
  • 01.03: the route ends on (18, 29) below Roark; his first line comes within TALK's 8 s; the scene's 5 s quiet rule does not end inside his lines or before he has walked off (the old event pressed B for 35 s and checked his tile with A).
  • 01.03 (from the decomp's warps and r103): north from (15, 2) goes up to the hall onto (11, 21); 19 taps north and a step out land on the city's (45, 59); north stops below the mine's sign on (45, 57); the heal from (47, 21) goes in (or lines up on the lit doorway) and comes out on (46, 21) or (47, 21).
  • 01.04: the gym event's 20 taps west from wherever the heal leaves us reach the Gym's door column (they were measured from walk_out_of_center()'s exit).
  • 01.11: 8 taps west from (11, 29) all move (the event allowed 7 counted); north stops below the old woman on (3, 26); a tap west, then the talk's turn north faces the old man.

Testing

Built locally; code health 0 failures. Unit tests were not run locally (a lab app is open on console B, and test mode switches its panel): the mac CI is dispatched on this branch, and on tmp/shared-steps-sim, a throwaway merge of this branch with bdsp/sim (#167, not to be merged) that adds GridSim runs for 00.05, 00.04d to 00.05c, 01.01 to 01.02, 01.03, 01.02 to 01.05, 01.05 to 01.10, 01.11, 00.05 to 01.11, and detector misses for 01.02 to 01.04. In that sim, Barry's talk in 01.03 is stubbed (the maps have no Barry).

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine and others added 7 commits November 2, 2026 11:12
The Starly battle is a BATTLE step, variant "starter" (fight_starly(): no
talk first, no Poke Balls, and the scene goes on either way), and the walk
out of the lake after it a MASH scene that ends on the Lakefront's quiet
overworld, instead of Butters' fixed 60 s of B.

Stays named: starter_briefcase (B until an image match of the open
briefcase) and choose_starter (the briefcase's cursor from the program's
starter option): menus only BDSP has.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Rowan's Pokedex is a MASH scene ending at Rowan in the lab, through the
fade into it. Butters' sequence pressed B through Dawn's and Rowan's
lines and the nickname question, then A for the Pokedex; the scene's B
answers the question No too, and closes an item's lines as it closed
Barry's parcel in 00.04 (r45).

Stays named: nothing in 00.03.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Barry's Town Map is a TALK west from beside him at the School's back wall
(the walk there now says it ends facing him) and a MASH scene with A to
"You obtained a Town Map!". The event's second try, north to the wall
again when he did not answer, is not kept: the walk north already ends
on the wall.

Stays named: up_the_steps. It taps a tile west and two north from 00.05's
save below Jubilife's steps, and that save's tile is not known (the map
has only where the taps end, "up_the_steps", column 46 or 47 a few rows
up), so the row has no start pose for a LEGS step to walk from. It needs
the save's tile measured on the console, as a point on JubilifeCity's map.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
01.01 starts where 00.05c ends, (58, 22) on Jubilife's street east to
Route 203, and is planned on the joined Route 203 and Jubilife: a route
to (4, 18) on Route 203, a step east onto Barry's coord event (column 5,
rows 17 to 20, VAR_ROUTE_203_RIVAL_STATE 0, Diamond's zone event
narc_0329), then his battle, which leaves us on the trigger (assumed).

Dropped with jubilife_center_to_street: its start from a save at the
Jubilife Center's PC (two tiles south, three west, the nurse, then stick
holds to the street). A save there no longer starts 01.01; the row's save
is made on the street. Dropped with east_to_barry: its walk east row by
row past walls, which the plan replaces.

Stays named: nothing in 01.01.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
01.02 starts on Barry's trigger, where 01.01 ends, and is planned on
Route 203's, the Gate's and Oreburgh's maps with the Diamond decomp's
zone events (narc_0329, narc_0250, narc_0044):

- a route east along Route 203 to the Gate's warp tile (55, 9), fighting
  the trainers who see us, then a tap east to the Gate's banner;
- a route to (6, 22), a step onto the Hiker's coord event (7, 22), and a
  MASH scene for his HM Rock Smash and the Hidden Moves card after it
  (no dialogue box; the scene's B closes it, as the event's two B did);
- a route east along row 22 to (27, 22), fighting Picnicker Diana and
  Camper Curtis, now on the Gate's trainer list with ranges that reach
  the row; a tap east to Oreburgh's banner;
- a route to (9, 13), a step onto the coord event of the man at the
  entrance (10, 12..15), and a MASH scene for his walk to the Center
  and Barry's lines. Where it leaves us is not known, so the row ends
  there.

Dropped: the met_hiker flag (the walk east meeting the Hiker on its way;
the step onto his trigger is explicit now), and the walk east row by row
past walls. Events_Route203.cpp had only these events and is gone.

Stays named: nothing in 01.02.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
From all four of Barry's trigger rows at once the planner found no way
east (StorySimulation's poses chain): walk south down the trigger's
column to the cliff below row 20 first, as 01.08 does at its start.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
In the grid sim (bdsp/sim, merged locally), the walk east along the
Gate planned one leg to the wall on row 23, where both Curtis and Diana
see it: Curtis was fought under Diana's name, and her stop on the walk
on to the wall went unseen, so the route ended at (24, 23). Two routes
now, to (20, 22) past Curtis's column and on to (27, 22) past Diana's.

They come off the trainer list again: the grid sim does not know them
beaten in 01.05, and they stopped its walk back west. The walker fights
them as trainers the map lacks, one per route.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine and others added 7 commits November 2, 2026 12:58
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
01.03 starts where Oreburgh's welcome scene leaves us (now 01.02's end
too) and is planned on Oreburgh's map and the mine's coal room
(Diamond's zone events narc_0044 and narc_0197):

- east to the fence below the Center and north, the one known tile to
  plan from; two taps west below the door; Barry in it (TALK, MASH);
- a route down the door's column, round the Hiker's patch, to above the
  mine's warp tiles (44..48, 59) and a step onto them. The generator
  writes those tiles as doors (WARP_DOORS), so no plan stands on them;
- the entrance hall, which has no map, on 19 counted taps each way and a
  step onto its warp row: no hold that a wild battle could end;
- in the coal room (now a room world): down the corridor to the boulder,
  a route to below Roark, his talk and scene, a route back to the warp;
- out below the mine's sign (to the wall), a route to the Center's
  doorstep (46, 21), and the heal. 01.04 now starts there, outside, and
  its out_of_the_center event is gone.

TALK waits 8 s for a line, not 3: Roark's first comes after the camera
zooms in on us (r98).

Dropped: the nudges round the Center's door and below Roark (they made
up for stick holds; taps are whole tiles), the Roark-gone check by A
after his scene (the scene rule's quiet overworld ends it), and the
walks until a transition.

Stays named: 01.04's gym_until_roark_beaten. After a loss it walks back
from the Center keeping the battles' experience, which a reload of the
row's save would take away.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
01.11 starts at 01.10's end, (11, 29) facing north, and walks as the
console did (r250a, r251a): 8 taps west along row 29 (LEGS), north until
the old woman stops us (to_wall, anchored below her at (3, 26)), her
talk; a tap west (LEGS, anchored below the old man at (2, 26), facing
north, so the talk's turn only turns), his talk.

Dropped: the event's tolerance of one uncounted tap west (7 of 8); LEGS
wants all 8.

Events_Route204.cpp keeps only 01.09's Rock Smash.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
00.05 starts from a save at (48, 62), below Jubilife's steps (45..47, 61)
against the wall east of them, where 00.04d's Dawn scene now says it
leaves us: the old event went "a tile west, then up the steps" from
there, two taps north (2026-10-30). That tile is the event's numbers on
the map, not a measured one (#134).

up_the_steps is a LEGS step of the same taps, a tile west and two north,
ending on (47, 60); the route to the Center plans from that one tile,
not the steps' region (46..47, 58..60).

Events_Jubilife.cpp keeps only 00.05b's wandering clowns. The Events
header lists what stays named and why.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The Center's door is the decomp's (47, 20), as Sandgem's and Jubilife's
doors were where the console came out of them. The map's doorstep
(46, 21) only says where 01.04's 20 taps to the Gym were counted from,
so out of the Center we may be on either tile.

Barry's talk and the heal are now from (47, 21), a tap west of the
fence, not two. The heal still lines up on the lit doorway when north
finds no door.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ubilife

Two fixes for #173's CI (the BDSP simulation tests):

- 01.03's taps through the entrance hall had no world to walk on ("no
  world holds OreburghMineB1F"). The hall gets its map from the Diamond
  decomp (narc_0313, zone event narc_0196; the Hiker hidden by his flag),
  with its way up (11..13, 1) as doors, and a room world. Down, we land
  on (12, 1); up, on (11, 21).
- 00.04d's Dawn scene ended on Jubilife while the stairs step before it
  left the pose on Route 202, so the scene waited for a fade that never
  comes (the grid sim's "no fade ... map mismatch"; on the console it
  would have failed after 120 s). The stairs step now ends below
  Jubilife's steps, (48, 62).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The stairs into Jubilife were a STEP whose variant names the event
jubilife_stairs. Since the last commit gave it a pose after (below
Jubilife's steps, so Dawn's scene waits for no fade), a walk check that
holds STEPs to their pose after expected it on Jubilife (the grid sim,
which stubs events: "into_jubilife: ended on Route 202"). It is an event
like the others now (event(), GAME), run the same way by its variant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine

dayfine commented Nov 3, 2026

Copy link
Copy Markdown
Owner Author

Folded into #128 (merge 74d6099).

@dayfine dayfine closed this Nov 3, 2026
dayfine added a commit that referenced this pull request Nov 3, 2026
#128 now has seg01's planned 01.05 to 01.10 (#175) and the shared steps
(#173). Their executor changes go where this branch moved the walking
steps: per-world trainers, the Twins as a pair (ConsoleStoryStepIO::fight),
the "to_banner" tap (StoryStepIO::tap_to_banner), and the 8 s wait for an
answer to a talk (StoryWalkSteps::talk). The story sim taps to the banner
too, and walks a route on the joined world it plans on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant