Repository navigation
Recover BDSP interrupted legs through shared wall localization - #229
Merged
dayfine merged 16 commits intoNov 5, 2026
Merged
Conversation
dayfine
changed the title
…overy-tests # Conflicts: # SerialPrograms/Source/Pokemon/Navigation/Pokemon_WallRecovery_Tests.cpp
dayfine
marked this pull request as ready for review
November 5, 2026 20:40
dayfine
merged commit Nov 5, 2026
8c6acef
into
bdsp/autostory-mine-floaroma-wip
8 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
bdsp/autostory-mine-floaroma-wip(#226), now updated with merged nav-core #227. Shared nav-core files are absent from this diff; remaining changes are BDSP execution, map metadata handling and native test/build registration.A wild battle can leave BDSP short of its credited tap count, causing the next leg to use the wrong row. Preserve all legal interrupted-leg positions, clip to a safe common wall, then rejoin the intended endpoint and restore facing. Recovery is bounded; unknown encounter origin and unconfirmed transitions fail explicitly. Static WallPolicy operations receive StoryWorld as explicit context.
Recovery excludes wandering areas, NPC anchors, declared warps, unknown edges, map crossings and ledge hops. Map bytes, terrain and story legs are unchanged.
How to review
Validation
50 focused native cases pass. Current
e35a3a5a7has the identical source tree as tested17c50cfb1; its additional merge only connects refreshed parent ancestry. Canonical lint passes. Two formerly combined checks now register separately. Earlier full Linux execution passed all 90 BDSP AutoStory cases, with only the same 26 missing-image failures as its baseline; the latest full run is being dispatched. No console/save validation is claimed.Evidence, older CI runs and fidelity limits.