Repository navigation
Lint C++ header contracts and table-driven native test cases - #231
Merged
Merged
Conversation
dayfine
marked this pull request as ready for review
November 5, 2026 19:45
dayfine
added a commit
that referenced
this pull request
Nov 5, 2026
- Add descriptive header symbol comments and matching namespace close comments - Forward-declare public function templates before their definitions - Convert native unit tests to input/expectation table-driven cases
dayfine
added a commit
that referenced
this pull request
Nov 5, 2026
- Add descriptive header symbol comments and matching namespace close comments - Forward-declare public function templates before their definitions - Convert native unit tests to input/expectation table-driven cases
dayfine
added a commit
that referenced
this pull request
Nov 5, 2026
Clean up namespace closing comments, namespace-scope symbol documentation, and refactor unit tests to table-driven TestCase scenarios.
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
dayfine
added a commit
that referenced
this pull request
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
agents. This draft changes the fork's canonical Code Health tooling and coding rules only. It is separate from the C++ changes in #227; never merge the agents branch into a code branch.Code Health now checks namespace closing labels, comments on namespace-scope header symbols, public template API declarations before implementation helpers, with internal helpers defined in place, and structured native test cases. New/changed UnitTest classes receive a case with separate
inputandexpectationstructs and register a named table of designated rows. Untouched legacy declarations remain grandfathered.How to review
Read the new structural sections in
style.py, their negative/positive self-tests, and the CLI integration. All rules share the existing style entry point, lexer and parsed statements; no separatecontracts.pyor second parsing pass remains. It is a structural check, not a C++ type checker; the README spells out supported tables and the limits around external fixture types/macros.Validation
All 112 linter tests pass when CODE_HEALTH_REPO points to the code checkout; Agents Check CI passes (its notes-only checkout has one expected skip). Harness and standing-rule checks pass. The candidate gate rejects the original #227 with structural findings and passes its revised header/tests with zero findings. Each new rule has a captured red test followed by a passing counterpart. #227 also switches its old branch-local CI to the canonical agents linter workflow; merge this draft to activate these rules there and in the normal pre-push gate.