Repository navigation
Fix missing native test fixtures and MSVC narrowing warning - #243
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ap-resource-handoff
dayfine
marked this pull request as ready for review
November 8, 2026 04:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on fork #224 (
frlg/stage7-celadon) after merged #238. The diff is three files: one CI fixture pin, one RNG literal-type fix and documentation. No map data/pins change.Full native validation exposed two blockers. CI used only upstream CommandLineTests, so 69 existing FRLG image cases failed before exercising their detectors. MSVC also rejected the RNG search's
initializer_list<int>values being assigned touint16_tunder /WX.Pin the complete fixture set at
dayfine/CommandLineTests@d150a6c547434110a920f95ba7857b93d5bb9222(fixture fork #12). It contains all 69 required frames, preserves all 1,198 current upstream files byte-for-byte, and combines existing public fixture bytes. Assertions and test selection are unchanged. Explicitly type the two RNG top-bit literals as uint16_t, preserving their values; that fix is committed in owning stage-2 #214 atd633063b1and merged here.How to review: the workflow repository/SHA and resource README describe the fixture dependency; the only C++ change types two loop literals. The publication handoff must arrange the required image fixtures upstream before using an upstream-only test checkout.
The first fixture-complete Linux Clang run loaded the images and passed 33,026 cases, but exposed three missing expected-text sidecars. Fixture #12 now includes the original sidecar blobs as well; no expectations were generated or changed to match output.
Fresh full native matrix runs use current head
37d4bde7dce83034a0f4e4ca09b199833c20fd37:Results remain pending. Earlier failures are recorded as failures, not green detector evidence. No console, GUI, save or profile operations.