Repository navigation
Conversation
Combines existing public fixture bytes for native CI; no new captures or image edits. Includes fork PR #10/#11 and the moon-stone frame; preserves all current upstream files. PokemonFRLG/AutoStoryBattle/Miguel_DeleteMoveForBite_YesNo_True.png <- fda683e (9fbe945) PokemonFRLG/AutoStoryBattle/Misty_SentOutStarmie_YesNo_False.png <- fda683e (69f3eb3) PokemonFRLG/AutoStoryBattle/SSAnneRival_Pidgeotto_FoeHp_48of48.png <- fda683e (e4f23e1) PokemonFRLG/AutoStoryBattle/SSAnneRival_Raticate_FoeHp_7of48.png <- fda683e (be62a23) PokemonFRLG/AutoStoryBattle/SSAnneRival_SentOutKadabra_YesNo_False.png <- fda683e (9715255) PokemonFRLG/AutoStoryBattle/SSAnneRival_SentOutRaticate_YesNo_False.png <- fda683e (5277fef) PokemonFRLG/ItemListReader/ItemsPocketMoonStone_eng.png <- 11b5629 (ca4e835) PokemonFRLG/SummaryMovesReader/Oddish_KnownMoves_eng.png <- fda683e (1a819a6) PokemonFRLG/TeachScreenReader/MachineSet_eng.png <- fda683e (b2c653a) PokemonFRLG/WhiteDialogDetector/SSAnne1F_CorridorWorker_False.png <- 0d4ff32 (9fc622f) PokemonFRLG/WhiteDialogDetector/SSAnne1F_Corridor_False.png <- 0d4ff32 (4312d62) PokemonSV/DialogArrowDetector/ParadiseProtectionProtocol_BattleStart-20261106-130450.png <- upstream 9b657fe (f457b64)
The full native test run exposed three missing golden files after image loading succeeded. Preserve their original bytes and detector assertions. PokemonFRLG/TeachScreenReader/_MachineSet_eng.txt <- fda683e (4b4e367) PokemonFRLG/SummaryMovesReader/_Oddish_KnownMoves_eng.txt <- fda683e (2bc2c09) PokemonFRLG/ItemListReader/_ItemsPocketMoonStone_eng.txt <- 11b5629 (98c6842)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets fork main. Validation integration of existing public image fixtures and their expected-text sidecars; no images were newly captured or edited.
Arduino #238's full native suite was failing 69 image cases because CI checked out only the upstream fixture repository. Fork main already has 58 of those frames. This adds the remaining 11 FRLG frames from fork #10, fork #11 and
frlg/item-list-reader-moon-stone, plus the one newer upstream SV frame missing from fork main. The subsequent native run exposed three missing golden-text files; the follow-up commit adds their unchanged originals from the same fixture sources.The pinned dataset contains all 69 required frames and preserves all 1,198 current upstream files byte-for-byte. Each added file's original revision and Git blob hash are recorded in its commit message. Existing fixture PRs remain open for their own review.
Validation: complete tree inventory/blob comparison against upstream commit
9b657fee4a9a83e1ed09133b3ff46d3c3c55e271, and exact coverage of the 69 failing native image paths. Linux Clang's first pass loaded the images and passed 33,026 cases, with three missing-sidecar failures. Unchanged detector assertions are being rerun through Arduino #243 with fixture commitd150a6c547434110a920f95ba7857b93d5bb9222; fresh results remain pending.