Let one list child report its own accessibility role - #358
Open
rezabakhshilaktasaraei wants to merge 1 commit into
Open
Let one list child report its own accessibility role#358rezabakhshilaktasaraei wants to merge 1 commit into
rezabakhshilaktasaraei wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A painted list reports one role for all of its virtual children through accessibilityChildRole(), so a row that is not an item - the unread bar dividing the read messages from the unread ones in the message lists - was read as a list item as well.
accessibilityChildRoleAt(index) lets the owner give one child its own role and defaults to the list-wide one, so nothing changes for the existing lists. It is a separate name rather than an overload on purpose: an overloaded virtual makes clang's -Woverloaded-virtual fail every class that overrides only one of the two forms under the -Werror builds.
Used by telegramdesktop/tdesktop#31211 to expose the unread bar as a Separator, verified with NVDA on Windows 10: the bar is announced as "Unread messages, separator" and drops out of the selection item pattern, the messages around it are unchanged.