Skip to content

Let one list child report its own accessibility role #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rezabakhshilaktasaraei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Let one list child report its own accessibility role #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ui/accessible/ui_accessible_item.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,10 @@ QWindow *Item::window() const {

QAccessible::Role Item::role() const {
const auto parent = _parent.get();
return parent
const auto index = parent ? currentIndex() : -1;
return (index >= 0)
? parent->accessibilityChildRoleAt(index)
: parent
? parent->accessibilityChildRole()
: QAccessible::Role();
}
Expand Down
4 changes: 4 additions & 0 deletions ui/rp_widget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,10 @@ QAccessible::Role RpWidget::accessibilityChildRole() const {
return QAccessible::Role::NoRole;
}

QAccessible::Role RpWidget::accessibilityChildRoleAt(int index) const {
return accessibilityChildRole();
}

QString RpWidget::accessibilityChildName(int index) const {
return QString();
}
Expand Down
7 changes: 7 additions & 0 deletions ui/rp_widget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,13 @@ class RpWidget : public RpWidgetBase<QWidget> {
[[nodiscard]] virtual QAccessible::State accessibilityChildState(int index) const;
void accessibilityChildStateChanged(int index, AccessibilityState changes);
[[nodiscard]] virtual QAccessible::Role accessibilityChildRole() const;

// The role of one child where it differs from the list-wide one above:
// a divider row between the items of a list is a Separator, not one
// more item. Defaults to accessibilityChildRole().
[[nodiscard]] virtual QAccessible::Role accessibilityChildRoleAt(
int index) const;

[[nodiscard]] virtual QRect accessibilityChildRect(int index) const;
[[nodiscard]] virtual int accessibilityChildColumnCount(int row) const;
[[nodiscard]] virtual QAccessible::Role accessibilityChildSubItemRole() const;
Expand Down