Skip to content

feat(homepage): add GitHub organization views and Marketplace - #5488

Merged
devantler merged 4 commits into
mainfrom
codex/homepage-marketplaces-5487-current
Oct 28, 2026
Merged

devantler merged 4 commits into
mainfrom
codex/homepage-marketplaces-5487-current

Conversation

@devantler

@devantler devantler commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Useful GitHub organization views are missing from the platform homepage. An intermittent failure in an existing test also blocked the required validation.

What

Adds shortcuts for repository rules, properties, audit history, rule activity and code quality in the relevant sections, plus GitHub Marketplace under a new Marketplaces section. Corrects the test fixture so the existing bootstrap checks run reliably.

Fixes #5487

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between be0e7e0 and 84a3980.

Files selected for processing: 2
  • k8s/bases/apps/homepage/config-map.yaml
  • scripts/private-mail-config/bootstrap_test.go

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 4fc2b84 and 35e1f95.

Files selected for processing: 1
  • k8s/bases/apps/homepage/config-map.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 28
  • GitHub Check: CodeRabbit
  • GitHub Check: zizmor
  • GitHub Check: ⚖️ Validate Cluster Policies (observability)
  • GitHub Check: 🏷️ Validate Naming Conventions
  • GitHub Check: 🔐 Validate Flux Credential Bridge
  • GitHub Check: 🧩 Compile WebApp with pinned KRO
  • GitHub Check: ⚖️ Validate Cluster Policies (storage)
  • GitHub Check: ⚖️ Validate Cluster Policies (fixtures)
  • GitHub Check: 🏷️ Validate Floating Image Tags
  • GitHub Check: 🧪 Validate Manifests
  • GitHub Check: ⚖️ Validate Cluster Policies (services)
  • GitHub Check: ⚖️ Validate Cluster Policies (tenant)
  • GitHub Check: 🛟 Validate PodDisruptionBudget Selectors
  • GitHub Check: 🧩 Validate Helm Post-Renderers
  • GitHub Check: ⚖️ Validate Cluster Policies (placement)
  • GitHub Check: 🧪 Validate Independent Manifest Regressions
  • GitHub Check: 🔬 Validate Nested RGD Templates
  • GitHub Check: 🔐 Validate Production Authorization
  • GitHub Check: 🛡️ Validate Repository Guards
  • GitHub Check: 🧪 Validate Complete Go Regressions
  • GitHub Check: 🔏 Validate Cosign Matcher Efficacy
  • GitHub Check: 🔐 Validate Publication Generator
  • GitHub Check: 🔐 Validate Consumer Discovery Regressions
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (actions)
Additional context used
Code guidelines: 1
AGENTS.md — auto-discovered
Path-based instructions: 2
Source excerpt: **Put a change in the layer that matches its scope** — edit `k8s/bases/` when it should hold for **every consumer of that resource**; add an overlay `patches/` fragment only for a genuine per-consumer difference.

CodeRabbit inference engine (AGENTS.md)

Files:

  • k8s/bases/apps/homepage/config-map.yaml
Source excerpt: **One Kubernetes resource per file** — patch fragments included.

CodeRabbit inference engine (AGENTS.md)

Files:

  • k8s/bases/apps/homepage/config-map.yaml
Learnings: 2
Learning: 2026-06-28T20:39:18.315Z
Learnt from: devantler
Repo: devantler-tech/platform PR: 2322
File: k8s/bases/apps/homepage/config-map.yaml:171-173
Timestamp: 2026-06-28T20:39:18.315Z
Learning: In `k8s/bases/apps/homepage/config-map.yaml`, the homepage `bookmarks.yaml` content is intentionally centralized in the base `ConfigMap`. Shared/global bookmarks that are identical across environments should remain in the base rather than being moved to overlays, and overlay patching is not preferred here because the bookmarks are stored as an embedded multi-line YAML string.

Applied to files:

  • k8s/bases/apps/homepage/config-map.yaml
Learning: 2026-07-10T21:20:15.096Z
Learnt from: devantler
Repo: devantler-tech/platform PR: 2575
File: k8s/bases/apps/homepage/config-map.yaml:167-169
Timestamp: 2026-07-10T21:20:15.096Z
Learning: In devantler-tech/platform, `k8s/bases/apps/homepage/config-map.yaml`'s `bookmarks.yaml` (and similarly `services.yaml`, `settings.yaml`) are embedded block-scalar strings shared across provider overlays (Hetzner, Docker). Individual bookmark/service entries in these blocks should stay in the base rather than being moved to overlay Kustomize patches, since patching a single line would require duplicating the entire embedded YAML blob. This shared-base pattern was established in PR #2322 and is validated by `scripts/validate-homepage-bookmarks.py` on `main`.

Applied to files:

  • k8s/bases/apps/homepage/config-map.yaml
Additional comments: 1
k8s/bases/apps/homepage/config-map.yaml: 1

145-146: LGTM!

Also applies to: 341-344

Walkthrough

The Homepage configuration adds a Marketplaces group with a storefront icon. It also adds a GitHub Marketplace bookmark with a GitHub icon and link.

Priority: Low

Merge Risk: Minimal · previous review 35e1f

The homepage additions are consistent with the stated Marketplace layout and bookmark requirements.

Pre-merge checks: Passed 4
Check name Status Explanation
Linked Issues check Passed The PR implements the coding requirements in #5487. In k8s/bases/apps/homepage/config-map.yaml, the layout places Marketplaces beside Package Registries and assigns a storefront icon. The bookma…
Out of Scope Changes check Passed The reviewed changes are limited to the homepage configuration required by #5487: the Marketplaces layout entry and the corresponding GitHub Marketplace bookmark. The changes support the requested h…
Title check Passed The title identifies the GitHub Marketplace homepage change, which matches the main objective. The reference to GitHub organization views is not supported by the provided change summary.
Description check Passed The description is related to the changeset. It explains the homepage additions and explicitly includes the GitHub Marketplace link.
Full details: Linked Issues check

Explanation

The PR implements the coding requirements in #5487. In k8s/bases/apps/homepage/config-map.yaml, the layout places Marketplaces beside Package Registries and assigns a storefront icon. The bookmarks configuration adds GitHub Marketplace with a GitHub icon and https://github.com/marketplace. The remaining acceptance items concern validation, merge workflow, deployment, and live observation; these are non-coding delivery tasks.

Full details: Out of Scope Changes check

Explanation

The reviewed changes are limited to the homepage configuration required by #5487: the Marketplaces layout entry and the corresponding GitHub Marketplace bookmark. The changes support the requested homepage section and do not show an unrelated feature or scope expansion.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Validation at 35e1f95508ed70d936c1e12d4091aa9080bdfeee: the existing bookmark validator accepts all 24 bookmarks across 8 groups; both environment manifest validations exit 0 and explicitly include the changed Homepage ConfigMap. Local Helm rendering was incomplete because the credential helper is unavailable, so this does not claim full Helm coverage. Hosted checks remain the gate for their selected validation.

User evaluation: inspected the resulting Homepage configuration and confirmed Marketplaces follows Package Registries, contains GitHub Marketplace, and uses the existing GitHub icon and official HTTPS destination. The new group is a bookmark group, so it does not broaden service-discovery admission. The live browser baseline lacks the group. Production rendering and click-through will be verified after the normal queue deployment, rather than inferred from source validation.

The production Kustomize render was also inspected: the new layout entry resolves to mdi-storefront-outline, and the bookmark resolves to https://github.com/marketplace with si-github-#181717.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-28T05:21:19.221890Z 8a0b1c8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Related test stability issue: #5489. Initial CI run 40635771590 failed because the parent observed an empty PID file in the child fixture. The unchanged focused test reproduced that failure locally across 200 repetitions. At 8a0b1c826aa1559b2764296abbc858fb82ac786e, publishing the completed PID by rename passes all 200 repetitions, and the full go test ./scripts/... suite passes. The original process cleanup, concurrent initializer and separate recovery-port assertions remain intact.

The Homepage configuration and validation results from the earlier comment are unchanged. CodeRabbit's previous green applies to the earlier commit only. Its fresh capacity receipt reports zero included reviews remaining in the hourly window, so a new Codex review was requested for this head.

@devantler devantler changed the title feat(homepage): add GitHub Marketplace under Marketplaces feat(homepage): add GitHub organization views and Marketplace Oct 28, 2026
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 58 minutes.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Validation at 84a3980da808f0fb38ec19a46d9c156dc835670c: the existing validator accepts 25 bookmarks across eight groups; the private-mail configuration, Homepage validator and actual Homepage bookmark regression packages pass. Both local and production manifest validations exit 0 and explicitly include the changed ConfigMap. Local OCI Helm renders have the previously recorded credential-helper limitation; hosted checks remain required.

User evaluation: followed the current GitHub organization navigation to verify Rulesets, Repository Properties, Ruleset Insights, Ruleset Dashboard, Audit Log and Code Quality destinations. Inspected the production Kustomize output to confirm the requested category placement and the Marketplace link. Live Homepage rendering and click-through remain the post-deployment verification step.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@devantler

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 84a3980. Configure here.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Ready at 84a3980da808f0fb38ec19a46d9c156dc835670c: both environment manifest validations and the focused regression packages pass. Hosted checks are settled, including the required CI aggregate. Cursor Bugbot check 122692324449 succeeded at this exact head, and its review reports no new issues. The complete thread read returns zero unresolved threads; no comment-form findings or maintainer asks remain.

The current main validation at 8e19401e598c738dc31917edbc2dff9a12c84f29 passed, the branch merges cleanly with that base, and live platform health passes. GitHub reports CLEAN. The gate helper still labels the opaque configured Code Quality rule UNVERIFIED; the normal protected merge queue remains the authority for that rule.

Current GitHub destinations and the production render were checked as a user. Live Homepage rendering and navigation will be verified after deployment.

@devantler
devantler marked this pull request as ready for review October 28, 2026 07:51
@devantler
devantler added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 7b32a6c Oct 28, 2026
54 checks passed
@devantler
devantler deleted the codex/homepage-marketplaces-5487-current branch October 28, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Add GitHub organization views and Marketplace to Homepage

1 participant