refactor: weekly cleanup for shared ICON_NAMES, story catalog, and agent docs - #441
Merged
Merged
Conversation
…ent docs Keep Storybook Icon/IconButton controls in lock-step with the bundled glyph set, document Header search and Footer cookie settings, and correct the Node pin plus HTTPS dev script in agent docs.
Bundle ReportChanges will increase total bundle size by 635 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: portfolio-server-cjsAssets Changed:
view changes for bundle: portfolio-client-array-pushAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 357 357
Lines 9109 9110 +1
Branches 2997 2997
=======================================
+ Hits 8887 8888 +1
Misses 216 216
Partials 6 6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⇛pull request
*ਈ✩‧₄˚༺☆༻*ਈ✩‧₄˚
what & why
Weekly code cleanup: Icon and IconButton stories now share
ICON_NAMES(including the missingcloseglyph), the Storybook catalog matches the public UI surface, Header/Footer autodocs cover search and cookie settings, and agent docs pick up the Node 24.21.0 pin plusdev:https. No product behavior change.scope
AGENTS.md/CLAUDE.md,apps/storybook,@httpjpg/uichange type
refactor/style/revert· Changed · patchbuild/ci/docs/test· Tooling · patchchecklist — every pull request
pnpm lint,pnpm type-check,pnpm testpass locally (pnpm test:coverage: statements 97.05%, lines 97.30%, functions 95.94%, branches 93.52%). Full Next.jspnpm buildwas not run (no app secrets in this environment).CLAUDE.md— I read a neighbouring file before inventing a pattern"use client"boundary is as small as possible@httpjpg/tokensvia Panda (no raw hex outside genuinely off-palette decoration)uinever imports back from consumers)packages/env/src/env.mjs,.env.exampleandturbo.json*.test.ts(x)); E2E updated if a user-facing flow changedconsole.login shipped paths; errors reported through@httpjpg/observabilitypackage.jsonversion,.release-please-manifest.jsonorCHANGELOG.mdnotes for reviewers
@types/node(deps: update dependency @types/node to ^24.13.5 #437), GitHub Actions (deps: update github actions #433), plus majors pnpm 12 (deps: update pnpm to v12 #422) and vitest 5 (deps: update vitest monorepo to v5 #424).CLAUDE.mdis a symlink toAGENTS.md.