Repository navigation
fix: revoke the participant's credentials when a VPA is disposed - #233
Merged
Merged
Conversation
The onboarding agent's dispose never revoked anything. It queried the IssuerService for credentials whose holder ID is the participant context ID, but the IssuerService records the credential subject (the participant's DID) as the holder ID, so the query found nothing. Even with results, the revoke request put the tenant's participant context in the path instead of the issuer's, and passed the verifiable credential's ID where the IssuerService expects the ID of its credential resource. QueryCredentialsByType now takes the holder ID separately from the participant context the token is bound to, and the agent passes the DID from cfm.participant.id. RevokeCredential uses the issuer's participant context in the path, and the agent revokes the credential resource ID. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jimmarino
approved these changes
Nov 11, 2026
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disposing a VPA never revoked the participant's credentials in the IssuerService. Three things were wrong:
QueryCredentialsByTypenow takes the holder ID separately, and the agent passes the DID fromcfm.participant.id.🤖 Generated with Claude Code