Skip to content

[variadic-parameters] Polish the concept docs - #948

Merged
IsaacG merged 1 commit into
exercism:mainfrom
IsaacG:rewrite.variadic-parameters
Oct 7, 2026
Merged

IsaacG merged 1 commit into
exercism:mainfrom
IsaacG:rewrite.variadic-parameters

Conversation

@IsaacG

@IsaacG IsaacG commented Sep 30, 2026

Copy link
Copy Markdown
Member

Work largely done with Gemini 3.8 Flash

Work largely done with Gemini 3.8 Flash
@IsaacG IsaacG added x:module/concept Work on Concepts x:type/content Work on content (e.g. exercises, concepts) x:type/docs Work on Documentation ready-to-translate labels Sep 30, 2026
exercism-i18n Bot added a commit to exercism/i18n that referenced this pull request Sep 30, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@exercism-i18n

exercism-i18n Bot commented Sep 30, 2026

Copy link
Copy Markdown

This PR has been translated 🚀

@exercism-i18n

exercism-i18n Bot commented Oct 1, 2026

Copy link
Copy Markdown

This PR has been translated 🚀

@exercism-i18n

exercism-i18n Bot commented Oct 1, 2026

Copy link
Copy Markdown

This PR has been translated 🚀

@IsaacG IsaacG closed this Oct 5, 2026
@IsaacG IsaacG reopened this Oct 5, 2026
iHiD added a commit to exercism/translator that referenced this pull request Oct 7, 2026
The completeness check on a source PR reads refs/pull/<n>/merge and
requires every file that differs from its first parent. The queue
translated the PR's head instead. When main edits a file the PR also
edits, the merged file is a third text that neither commit holds, so
the check stays red and every re-run of the issue finds nothing to do.
exercism/swift#948 hit this with lasagna-master's introduction after
#933 landed on main.

source-checkout.mjs now fetches the merge ref with the PR head, and
the issue scope compares it with its first parent when its second
parent is the issue's sha. Without a usable merge ref (a conflicting
PR), the scope falls back to the head and its merge base as before.
The run records the ref it used, and issue-failures.mjs reads English
there.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
exercism-i18n Bot added a commit to exercism/i18n that referenced this pull request Oct 7, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@exercism-i18n

exercism-i18n Bot commented Oct 7, 2026

Copy link
Copy Markdown

This PR has been translated 🚀

@iHiD

iHiD commented Oct 7, 2026

Copy link
Copy Markdown
Member

A note from Claude (the AI agent that runs Exercism's translation pipeline), posting on iHiD's behalf.

The i18n / completeness check was failing because of a bug in the translation queue. Nothing in this PR caused it. #933 landed on main after this PR branched, and it also edited exercises/concept/lasagna-master/.docs/introduction.md. The completeness check tests the PR as merged into main, so it needed a translation of the combined version of that file. The queue only translated the PR's own version, so every re-run found nothing to do and the check stayed red.

The queue now translates the PR as it would be merged (exercism/translator#29). It has translated the combined file into every locale, and the check passes. This PR should be mergeable now.

@IsaacG
IsaacG merged commit 48a8008 into exercism:main Oct 7, 2026
48 of 55 checks passed
@IsaacG
IsaacG deleted the rewrite.variadic-parameters branch October 7, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-translate x:module/concept Work on Concepts x:type/content Work on content (e.g. exercises, concepts) x:type/docs Work on Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants