Repository navigation
Translate a queue issue at the PR's merge ref - #29
Merged
Merged
Conversation
The completeness check on a source PR reads refs/pull/<n>/merge and requires every file that differs from its first parent. The queue translated the PR's head instead. When main edits a file the PR also edits, the merged file is a third text that neither commit holds, so the check stays red and every re-run of the issue finds nothing to do. exercism/swift#948 hit this with lasagna-master's introduction after #933 landed on main. source-checkout.mjs now fetches the merge ref with the PR head, and the issue scope compares it with its first parent when its second parent is the issue's sha. Without a usable merge ref (a conflicting PR), the scope falls back to the head and its merge base as before. The run records the ref it used, and issue-failures.mjs reads English there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The completeness check on a source PR reads
refs/pull/<n>/merge, but the queue translated the PR head. Whenmainedits a file the PR also edits, the merged file is a blob neither commit holds, so the check stays red and re-runs of the issue report nothing to do. exercism/swift#948 hit this: #933 changedexercises/concept/lasagna-master/.docs/introduction.mdonmain, and the check wants blob4256a5cf, which only the merge ref has.The queue now fetches the merge ref and translates at it when its second parent is the issue's sha, falling back to the head and its merge base when GitHub has no merge ref.
issue-failures.mjsreads English at the ref the run used.node scripts/test.mjs: 59 passed. A dry run of the new scope over swift#948 picks up the lasagna-master introduction.🤖 Generated with Claude Code