fix: release SuperKMeans sample buffer after rotation - #5648
Closed
marcelo-cjl wants to merge 2 commits into
Closed
marcelo-cjl wants to merge 2 commits into
marcelo-cjl wants to merge 2 commits into
Conversation
Contributor
|
@alibeklfc has imported this pull request. If you are a Meta employee, you can view this in D121294074. |
Contributor
|
@alibeklfc merged this pull request in 3f08095. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X_tildeMemory result
One build run on Cohere 1M x 768 FP32 with SCANN (
nlist=1024,sub_dim=2,with_raw_data=false, 16 threads):The released sample buffer is 768 MiB. The measured reduction is smaller because average RSS is time-weighted over the full build; the buffer is still required during sampling and rotation.
Test plan
faiss_testtarget in Release modefaiss_test --gtest_filter='AdSampling.*:PdxLayout.*:BlockL2.*:SuperKMeansAssignIteration.*'(13 tests passed)Closes #5650