Repository navigation
feat: add admin management of OpenID Provider applications - #525
Merged
Merged
Conversation
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Admin management of OpenID Provider applications (clients), per ADR 0001 D6, D10 and D12. Reads need
admin:read. Every write needsadmin:writeplus a fresh step-up and writes anadmin_oidc_application_*auth event. The routes work whether or notoidc_provider_enabledis on.GET /admin/applicationsPOST /admin/applicationsGET /admin/applications/:idPATCH /admin/applications/:iddisabled: trueDELETE /admin/applications/:idoidc_payloadswherepayload->>'clientId')POST /admin/applications/:id/secretPUT /admin/applications/:id/keysprivate_key_jwtInsecure settings cannot be created (#410). The rules come from
@seamless-auth/types(checkOidcApplication) and run on create and again on the merged result of every update:client_credentials.private_key_jwt.client_secret_jwtcannot be expressed.The API adds the instance checks: shared secrets need
allow_client_secrets, and third-party clients needthird_party_clients_enabled. Moving offprivate_key_jwtdrops the keys, and moving off a shared-secret method drops the secret.Client model parts of #508. Redirects follow RFC 8252:
https.httponly on127.0.0.1or[::1], with any port at request time.localhost, fragments or credentials.The registry now decides
application_type: nativewith the same rule.Also adds the
hosted_uisystem config key (OIDC_HOSTED_UI, defaultnull) from types#97, plus a docs section with the enforcement matrix.Contract change. These routes are access passthroughs in the adapter manifest and need seamless-auth-server#241, dashboard#296 and cli#276.
Types
Locks the published
@seamless-auth/types0.34.0-next.1 (fells-code/seamless-auth-types#125).Closes #407
Part of #508, #410
Checks (local, against the published types 0.34.0-next.1)
npm run typecheck,npm run lint,npm run format:check,npm run build: passnpm run coverage: 165 files, 2582 tests pass; 99% lines, 95.73% branchesTEST_DB=postgresproject on a scratch Postgres 16: 48 tests pass, including the JSONB delete/security-review: no findings