Skip to content

fix(vroom): Run the healthcheck without a shell #4534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oioki merged 3 commits into from
Oct 7, 2026
Merged

fix(vroom): Run the healthcheck without a shell #4534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dfe934
fix(vroom): Run the healthcheck without a shell
oioki Oct 6, 2026
4b10091
Merge branch 'master' into alextarasov/vroom-shell-free
oioki Oct 6, 2026
9d3db1a
fix(external-kafka): Update vroom healthcheck context in patch
oioki Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,12 +682,7 @@ services:
- sentry-vroom:/var/vroom/sentry-profiles
healthcheck:
<<: *healthcheck_defaults
test:
- "CMD"
- "/bin/bash"
- "-c"
# Courtesy of https://unix.stackexchange.com/a/234089/108960
- 'exec 3<>/dev/tcp/127.0.0.1/8085 && echo -e "GET /health HTTP/1.1\r\nhost: 127.0.0.1\r\n\r\n" >&3 && grep OK -s -m 1 <&3'
test: ["CMD", "/bin/vroom", "healthcheck"]
depends_on:
kafka:
Comment thread
sentry[bot] marked this conversation as resolved.
<<: *depends_on-healthy
Expand Down
8 changes: 2 additions & 6 deletions optional-modifications/patches/external-kafka/docker-compose.yml.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
taskscheduler:
<<: *sentry_defaults
command: run taskworker-scheduler
@@ -826,14 +804,23 @@
@@ -826,20 +804,26 @@
<<: [*restart_policy, *pull_policy]
image: "$VROOM_IMAGE"
environment:
Expand All @@ -161,11 +161,7 @@
+ - ./certificates/kafka:/kafka-certificates:ro
healthcheck:
<<: *healthcheck_defaults
test:
@@ -842,9 +829,6 @@
- "-c"
# Courtesy of https://unix.stackexchange.com/a/234089/108960
- 'exec 3<>/dev/tcp/127.0.0.1/8085 && echo -e "GET /health HTTP/1.1\r\nhost: 127.0.0.1\r\n\r\n" >&3 && grep OK -s -m 1 <&3'
test: ["CMD", "/bin/vroom", "healthcheck"]
- depends_on:
- kafka:
- <<: *depends_on-healthy
Expand Down
Loading