Repository navigation
fix(vroom): Run the healthcheck without a shell - #4534
Merged
Merged
Conversation
Coverage Results 📊✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 11m 2s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 50%). Coverage diff@@ Coverage Diff @@
## master #4534 +/-##
==========================================
Coverage 95.52% 95.52% —%
==========================================
Files 5 5 —
Tracked lines 335 335 —
Branches 0 0 —
==========================================
Hits 320 320 —
Misses 15 15 —
Partials 0 0 —Generated by Coverage Action |
aldy505
reviewed
Sep 29, 2026
aldy505
left a comment
aldy505
left a comment
Collaborator
There was a problem hiding this comment.
Not sure on whether to approve this.
|
|
||
| # Generate some random files on `sentry-vroom` volume for testing | ||
| $dc run --rm --no-deps -v sentry-vroom:/var/vroom/sentry-profiles --entrypoint /bin/bash vroom -c ' | ||
| $dc run --rm --no-deps -v "${COMPOSE_PROJECT_NAME}_sentry-vroom:/var/vroom/sentry-profiles" --entrypoint /bin/sh seaweedfs -c ' |
Collaborator
There was a problem hiding this comment.
This would probably breaks users with custom/named volume.
Use the `vroom healthcheck` subcommand (getsentry/vroom#679) instead of a bash /dev/tcp probe, so the healthcheck keeps working once the vroom image has no shell. Co-Authored-By: Claude <noreply@anthropic.com>
oioki
force-pushed
the
alextarasov/vroom-shell-free
branch
from
October 6, 2026 21:31
bb9d187 to
6dfe934
Compare
oioki
changed the title
oioki
marked this pull request as ready for review
October 6, 2026 23:03
Member
Author
|
@aldy505 @aminvakil This PR only changes the healthcheck. The rest of concerns will be addressed in follow-up PRs. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
The vroom hunk used the old bash healthcheck as context, so it no longer applied after switching to `vroom healthcheck`. Merge the two vroom hunks into one with the new one-line healthcheck as context. Co-Authored-By: Claude <noreply@anthropic.com>
aldy505
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the vroom healthcheck from a bash
/dev/tcpprobe to["CMD", "/bin/vroom", "healthcheck"], so it keeps working once the vroom image has no shell.vroom healthcheck(getsentry/vroom#679) checks/healthon$PORT(default 8085) and is already inghcr.io/getsentry/vroom:nightly, so this can merge any time.The other places that run a shell in vroom (
ensure-correct-permissions-profiles-dir.shand the volume migration inbootstrap-s3-profiles.sh) are both past the 26.5.0 hard stop and will be removed in separate PRs.Refs SEC-1098