Repository navigation
ref(profiles): Drop the sentry-vroom volume migration - #4552
Merged
Merged
Conversation
The copy from the sentry-vroom volume into the profiles bucket shipped in 25.11.1, so every supported upgrade has run it at the 26.5.0 hard stop, and fresh installs have nothing to migrate. It also needs a shell in the vroom container, which a distroless vroom image won't have. Co-Authored-By: Claude <noreply@anthropic.com>
Coverage Results 📊✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 10m 48s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 50%). Coverage diff@@ Coverage Diff @@
## master #4552 +/-##
==========================================
Coverage 95.52% 95.52% —%
==========================================
Files 5 5 —
Tracked lines 335 335 —
Branches 0 0 —
==========================================
Hits 320 320 —
Misses 15 15 —
Partials 0 0 —Generated by Coverage Action |
oioki
marked this pull request as ready for review
October 7, 2026 10:59
aldy505
approved these changes
Oct 7, 2026
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the step in
bootstrap-s3-profiles.shthat copies files from thesentry-vroomvolume into the SeaweedFSprofilesbucket. It runsshandapt-getinside the vroom container, which won't work once the vroom image has no shell.Why it's safe: the step only runs when the
profilesbucket doesn't exist yet. The migration shipped in 25.11.1, so every supported upgrade created the bucket and copied the files at the 26.5.0 hard stop; after that the step is skipped. On a fresh install the volume is empty, so there's nothing to copy. Bucket creation, the config prompt and the lifecycle policy are unchanged, and thesentry-vroomvolume stays in place.Worst case: someone upgrading from 25.11.0 or older straight to this version, skipping the hard stops, keeps their old profiles in the
sentry-vroomvolume instead of the bucket, so those profiles don't show up in the UI. The install still succeeds and nothing is deleted. These profiles are over 11 months old, past the default 90-day retention, and a one-offs3cmd syncof the volume into the bucket (what the removed step did) recovers them.The unit test no longer seeds 1000 files into the volume (that also needed bash in vroom); it now checks that the
profilesbucket is created.Follow-up to #4534.