Conversation
5 tasks
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
2 times, most recently
from
August 24, 2026 20:17
737c9cf to
5d8e20b
Compare
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 24, 2026 20:52
5d8e20b to
464c7d0
Compare
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 24, 2026 20:57
464c7d0 to
1eb7910
Compare
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
2 times, most recently
from
August 31, 2026 17:05
21288e6 to
fec1a68
Compare
logaretm
changed the base branch from
awad/route-provider-api
to
awad/route-provider-tracing-naming
August 31, 2026 17:13
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 31, 2026 18:19
fec1a68 to
7016bab
Compare
logaretm
changed the base branch from
awad/route-provider-tracing-naming
to
awad/route-provider-api
August 31, 2026 18:19
logaretm
changed the title
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 31, 2026 18:28
7016bab to
fb24bbd
Compare
3 tasks
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
3 times, most recently
from
September 24, 2026 18:14
38c792e to
dff53f6
Compare
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
3 times, most recently
from
September 24, 2026 19:11
6727c7a to
13a1451
Compare
Member
Author
|
bugbot run |
Both routers already ship a pure matcher: the App Router has the build-time route manifest behind `maybeParameterizeRoute`, and the Pages Router matches against `__BUILD_MANIFEST.sortedPages`. Neither was reachable from anywhere except the pageload and navigation instrumentation. Registered from `init()` rather than `browserTracingIntegration`, because both manifests are on the global object before `Sentry.init` runs. Route parameterization no longer depends on tracing being enabled, so `bfcacheMetrics` resolves a parameterized route with `browserTracingIntegration` absent. The two manifests want the pathname differently, since App Router routes are generated with `basePath` baked in while Next strips it internally for the Pages Router, so the provider normalizes per manifest.
…named The provider was registered after `reactInit` returned, but the pageload span is named in `browserTracingIntegration`'s `afterAllSetup`, which runs inside it. So every App Router pageload lost its parameterized name. Registering it from a default integration's `setup` runs it before any `afterAllSetup` while still not depending on tracing.
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
September 24, 2026 19:59
13a1451 to
d20fbbe
Compare
logaretm
changed the title
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d20fbbe. Configure here.
logaretm
marked this pull request as ready for review
September 24, 2026 21:03
logaretm
requested review from
chargome and
nicohrubec
and removed request for
a team
September 24, 2026 21:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider for Next.js from the manifests already injected at build time, covering both the App Router and the Pages Router.
Registered from
init()rather than frombrowserTracingIntegration, which is the point of the change: both manifests are on the global object beforeSentry.initruns, so nothing has to wait for a router or for tracing.bfcacheMetricsIntegrationnow resolves a parameterized route withbrowserTracingIntegrationabsent entirely, and the same will hold for web vitals and interactions as they move over.The two manifests want the pathname differently, since App Router routes are generated with
basePathbaked in while Next strips it internally for the Pages Router, so the provider normalizes per manifest.Part of #23556