-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(nextjs): Register nextjs route provider #23552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8c7009b
feat(nextjs): Register a route provider outside the tracing integration
logaretm 3aba217
ref(nextjs): Drop the unused global alias from the Pages Router navig…
logaretm bb954bb
fix(nextjs): Register the route provider before the pageload span is …
logaretm 6a67a1f
ref(nextjs): Only require the pathname in the route provider
logaretm 76145c0
ref(nextjs): Import the route provider API from `@sentry/react`
logaretm 7421e0b
ref(nextjs): Pass the route provider as the `routeProvider` option
logaretm 661e77c
fix(nextjs): Only strip `basePath` at a path segment boundary
logaretm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import type { RouteProvider } from '@sentry/react'; | ||
| import { createUrlRouteProvider } from '@sentry/react'; | ||
| import { maybeParameterizeRoute, stripBasePath, stripTrailingSlash } from './parameterization'; | ||
| import { getNextRouteFromPathname } from './pagesRouterRoutingInstrumentation'; | ||
|
|
||
| /** | ||
| * Resolves a URL against whichever router manifest the app ships. | ||
| * | ||
| * App Router routes are generated with `basePath` baked in, which is what `location.pathname` gives | ||
| * us; Next strips it internally for the Pages Router, so the fallback strips it too. | ||
| */ | ||
| function resolveNextRoute(url: { pathname: string }): string | undefined { | ||
| const pathname = stripTrailingSlash(url.pathname); | ||
|
|
||
| return maybeParameterizeRoute(pathname) ?? getNextRouteFromPathname(stripBasePath(pathname)); | ||
| } | ||
|
|
||
| /** | ||
| * A route provider backed by the route manifests Next.js injects at build time. | ||
| * | ||
| * Both manifests are on the global object before `Sentry.init` runs, so this needs no router and no | ||
| * tracing integration: registering it is what lets anything else in the SDK name a route. | ||
| */ | ||
| export function createNextRouteProvider(): RouteProvider { | ||
| return createUrlRouteProvider(resolveNextRoute); | ||
| } | ||
|
cursor[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.