fix(seer): Handle non-2xx HTTP responses from severity-score endpoint - #125145
Open
sentry[bot] wants to merge 2 commits into
Open
sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a
JSONDecodeErrorthat occurred when the Seer/v0/issues/severity-scoreendpoint returned a non-2xx HTTP status code (e.g., 503 Service Unavailable).Previously, the
_get_severity_score()function insrc/sentry/event_manager.pywould attempt to parseresponse.datawithorjson.loads()immediately aftermake_severity_score_request(), without first checking the HTTP status code. When Seer returned an error status, the response body often contained an HTML error page, leading to aJSONDecodeError.The fix introduces a check for
response.status >= 400before attempting JSON parsing. If an error status is detected, anExceptionis raised. This exception is then caught by the existingexcept Exceptionblock, which gracefully handles the microservice error by setting thereasontomicroservice_errorand incrementing relevant metrics, thus preventing theJSONDecodeError.Additionally, a new metric tag
microservice_http_erroris added to distinguish these specific HTTP errors from other unknown microservice errors. A new test case has also been added totests/sentry/event_manager/test_severity.pyto cover this scenario.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5M0K
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.