Skip to content

fix(seer): Handle non-2xx HTTP responses from severity-score endpoint #125145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 2 commits into
base: master
Choose a base branch
from
+39 −0
Open

fix(seer): Handle non-2xx HTTP responses from severity-score endpoint #125145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c5910
fix(seer): Handle non-2xx HTTP responses from severity-score endpoint
sentry[bot] Sep 21, 2026
79cd50f
:hammer_and_wrench: apply pre-commit fixes
getsantry[bot] Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/event_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2226,6 +2226,8 @@ def _get_severity_score(event: Event) -> tuple[float, str]:
timeout=timeout,
viewer_context=viewer_context,
)
if response.status >= 400:
raise Exception(f"Seer severity endpoint returned HTTP {response.status}")
severity = orjson.loads(response.data).get("severity")
reason = "ml"
except MaxRetryError:
Expand Down
37 changes: 37 additions & 0 deletions tests/sentry/event_manager/test_severity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,43 @@ def test_timeout_error(
assert reason == "microservice_timeout"
assert cache.get(SEER_ERROR_COUNT_KEY) == 1

@patch(
"sentry.event_manager.severity_connection_pool.urlopen",
return_value=HTTPResponse(body=b"<html>Service Unavailable</html>", status=503),
)
@patch("sentry.event_manager.sentry_sdk.capture_exception")
@patch("sentry.event_manager.metrics.incr")
def test_http_error_response(
self,
mock_metrics_incr: MagicMock,
mock_capture_exception: MagicMock,
_mock_urlopen: MagicMock,
) -> None:
"""A non-2xx HTTP response (e.g. 503) should be handled gracefully without raising JSONDecodeError."""
manager = EventManager(
make_event(
exception={
"values": [
{
"type": "NopeError",
"value": "Nopey McNopeface",
"mechanism": {"type": "generic", "handled": True},
}
]
},
platform="python",
)
)
event = manager.save(self.project.id)

severity, reason = _get_severity_score(event)

mock_capture_exception.assert_called_once_with()
mock_metrics_incr.assert_any_call("issues.severity.error", tags={"reason": "unknown"})
assert severity == 1.0
assert reason == "microservice_error"
assert cache.get(SEER_ERROR_COUNT_KEY) == 1

@patch(
"sentry.event_manager.severity_connection_pool.urlopen",
side_effect=Exception("It broke"),
Expand Down
Loading