Skip to content

v1.9.6: docs — folder access lasts until the last tab closes, not one page load - #11

Merged
gitluis merged 2 commits into
masterfrom
docs-folder-access-lifetime
Oct 26, 2026
Merged

gitluis merged 2 commits into
masterfrom
docs-folder-access-lifetime

Conversation

@gitluis

@gitluis gitluis commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Independent of the other open PRs: branched from master, not stacked. It's numbered v1.9.6 (docs, patch bump) on the assumption that #9 (v1.9.5) merges first.

Summary

CLAUDE.md §14 and two code comments said Chromium drops a stored folder's permission on every page load. That's not what happens. Access lasts until the last FinLens tab closes. This PR corrects the docs and comments only. No code behavior changes.

Cause

The claim came from the v1.9.3 folder-permission fix (#7). Luis's Edge test of #9 contradicted it:

  • A reload kept access. The "Backups paused" banner didn't come back.
  • Closing Edge completely dropped it. The banner appeared after reopening the profile.

That matches Chrome's documentation:

  • Access lasts until the last tab of the site closes.
  • Chrome can revoke it after a tab sits in the background for a while.
  • Since Chrome 122, the re-request prompt can offer Allow on every visit, which keeps access until the user revokes it.

The code already checks permission on every load and every save, so it handles all of these. Only the explanation was wrong.

What changed

  • CLAUDE.md §14: the first "Folder permission" bullet now describes how long access actually lasts, and says not to rely on any of it.
  • js/core.js: the comment above folderPermission(), and the one in saveStateToFile().
  • js/init.js: the comment above updateFolderBanner().
  • Version v1.9.6 per §17: CHANGELOG.md, index.html footer, README.md (twice), js/views-settings.js, and CLAUDE.md §1 and its "Last updated" line.

How it was tested

Headless Chromium against samples/ on this branch:

  • Boot: imported the 257 sample transactions.
  • All 23 registered views: rendered with no errors. The only console error was the Google Fonts stylesheet, which the test harness blocks.
  • Version: the footer and Settings → General both show v1.9.6.
  • Syntax: core.js and init.js pass node --check.

Not tested:

  • Closing only the FinLens tab while Edge stays open. Chrome's documentation says that also drops access. Luis's test closed Edge completely.

Merging with #9

Please check before merging


Generated by Claude Code

…d; v1.9.6

CLAUDE.md §14 and comments in core.js and init.js said Chromium resets a
stored folder's permission on every page load. Luis's Edge test of #9
showed otherwise: a reload kept access, and the "Backups paused" banner
only came back after closing Edge completely. That matches Chrome's
documented behavior: access lasts until the last tab of the site closes,
can be revoked after a tab sits in the background, and since Chrome 122
the prompt can offer "Allow on every visit".

The code already checks permission on every load and save, so nothing
else changes. Version strings bumped to v1.9.6 per CLAUDE.md §17.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S7caAyxvQu782xY9pDnmPG
PR #11 was branched before #9 (v1.9.5) merged, so the version strings,
CHANGELOG.md and the CLAUDE.md footer conflicted. Resolved by keeping
v1.9.6 everywhere, ordering the changelog 1.9.6 → 1.9.5 → 1.9.4, and
keeping master's v1.9.5 entry in the CLAUDE.md "Last updated" line.
No other changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019JQE8BsrWkojjpK1xAUMgr
@gitluis

gitluis commented Oct 26, 2026

Copy link
Copy Markdown
Owner Author

Review: docs only ✅

Reviewed at e87d07a. This PR changes only docs, code comments and version strings: CLAUDE.md §14, the comments in core.js and init.js, a CHANGELOG entry, and the bump to v1.9.6. No code that runs changed.

Check Result
Nothing but comments, docs and version strings changed ✅ 7 files, +19 / −11
The new wording matches how the browser behaves ✅ Matches the Edge test in #9 (a reload kept access; only closing Edge dropped it) and Chrome's docs: access lasts until the last tab closes, can be revoked after a tab sits in the background, and since Chrome 122 the prompt can offer Allow on every visit
"The code already checks permission on every load and save" ✅ loadStateFromFile() and saveStateToFile() both call folderPermission() before touching the file
Version strings (§17) ✅ v1.9.6 in CHANGELOG.md, the index.html footer, both README.md lines, Settings → General and CLAUDE.md §1
Conflicts with master ✅ Resolved in e87d07a. The branch was cut before #9 (v1.9.5) merged. The resolution keeps v1.9.6, orders the changelog 1.9.6 → 1.9.5 → 1.9.4, and keeps the v1.9.5 entry in the CLAUDE.md footer.

Notes (non-blocking)

Approved for merge at e87d07a.

gitluis commented Oct 26, 2026

Copy link
Copy Markdown
Owner Author

Approval recorded (chat)

Merging now.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants