Repository navigation
v1.9.6: docs — folder access lasts until the last tab closes, not one page load - #11
Merged
Merged
Conversation
…d; v1.9.6 CLAUDE.md §14 and comments in core.js and init.js said Chromium resets a stored folder's permission on every page load. Luis's Edge test of #9 showed otherwise: a reload kept access, and the "Backups paused" banner only came back after closing Edge completely. That matches Chrome's documented behavior: access lasts until the last tab of the site closes, can be revoked after a tab sits in the background, and since Chrome 122 the prompt can offer "Allow on every visit". The code already checks permission on every load and save, so nothing else changes. Version strings bumped to v1.9.6 per CLAUDE.md §17. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S7caAyxvQu782xY9pDnmPG
PR #11 was branched before #9 (v1.9.5) merged, so the version strings, CHANGELOG.md and the CLAUDE.md footer conflicted. Resolved by keeping v1.9.6 everywhere, ordering the changelog 1.9.6 → 1.9.5 → 1.9.4, and keeping master's v1.9.5 entry in the CLAUDE.md "Last updated" line. No other changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019JQE8BsrWkojjpK1xAUMgr
Owner
Author
Review: docs only ✅Reviewed at
Notes (non-blocking)
Approved for merge at |
Owner
Author
|
Approval recorded (chat)
Merging now. Generated by Claude Code |
This was referenced Oct 26, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.md §14 and two code comments said Chromium drops a stored folder's permission on every page load. That's not what happens. Access lasts until the last FinLens tab closes. This PR corrects the docs and comments only. No code behavior changes.
Cause
The claim came from the v1.9.3 folder-permission fix (#7). Luis's Edge test of #9 contradicted it:
That matches Chrome's documentation:
The code already checks permission on every load and every save, so it handles all of these. Only the explanation was wrong.
What changed
js/core.js: the comment abovefolderPermission(), and the one insaveStateToFile().js/init.js: the comment aboveupdateFolderBanner().CHANGELOG.md,index.htmlfooter,README.md(twice),js/views-settings.js, and CLAUDE.md §1 and its "Last updated" line.How it was tested
Headless Chromium against
samples/on this branch:core.jsandinit.jspassnode --check.Not tested:
Merging with #9
CHANGELOG.md.masterinto this branch and resolve them, keeping v1.9.5 below v1.9.6 in the changelog. That adds a new commit, so it needs a fresh approval.Please check before merging
master.Generated by Claude Code