Repository navigation
Conversation
- New db-tools view in views-db.js, shown as the last Settings tab, with DB Inspector and DB Schema sub-tabs. Both views still open on their own with showView(). - Settings hides a tab whose view isn't registered instead of throwing. - DB Inspector re-reads the store on every visit (was showing stale rows and a blank count line), keeping the chosen store, search and page. - README tips point to Settings → Import / Categories; CLAUDE.md §3, §12, §19 and the version strings updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YNVUix2HCeCPauBy4BHxFp
2 tasks done
… README views-data.js line
Owner
Author
|
Pushed
Re-tested headless on Generated by Claude Code |
This was referenced Oct 26, 2026
gitluis
pushed a commit
that referenced
this pull request
Oct 26, 2026
Luis decided on 2026-10-26 that #12 and #13 merge before #10. Master is at v1.10.0, so this bug fix is the patch release v1.10.1 (CLAUDE.md §17); #10 keeps v1.11.0. Renumbered in CHANGELOG, index.html, README, views-settings.js, CLAUDE.md §1/§13/§21/last-updated, and the views-eval.js comment on runs that didn't record maxTokens. No code change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QiRz5pTW83oqNbk2NC7yMR
gitluis
pushed a commit
that referenced
this pull request
Oct 26, 2026
…on to v1.10.2 #12 and #13 now merge before #10 (Luis, 2026-10-26), so #12 is v1.10.1 and this fix is v1.10.2; #10 keeps v1.11.0. Conflicts were only the version strings. Every v1.11.2 is now v1.10.2 and every v1.11.1 is v1.10.1 (CHANGELOG, index.html, README, views-settings.js, CLAUDE.md, and comments in views-ai.js and views-eval.js). No code change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QiRz5pTW83oqNbk2NC7yMR
This was referenced Oct 26, 2026
Open
…ty redesign (#16-#21) Brings the Clarity redesign (#16 -> #17 -> #19 -> #20 -> #21, v1.12.0 to v1.16.0) into #10 so the Settings -> Database tab can be rebuilt on it. Conflicts in CHANGELOG.md, CLAUDE.md, README.md, index.html and js/views-settings.js were resolved by taking the redesign's version of each file. #10's changes to them (the 1.11.0 entry and version strings, the Database tab in SETTINGS_TABS, the unregistered-tab guard, README tips, CLAUDE.md notes) are rebuilt on the new design in the next commit. js/views-db.js merged cleanly: the redesign's file plus #10's db-tools view and DB Inspector re-read fix. Both are restyled next. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
Rebuilds PR #10's tab on the Clarity redesign. Its v1.11.0 version predated the redesign and was never released; its CHANGELOG entry and version strings are gone, replaced by one 1.17.0 entry. - Settings: a seventh tab, Database, last, in plain text; part of the tablist (arrow keys, Home, End). A tab whose view isn't registered is hidden instead of throwing (#10's guard). On a phone the tab bar scrolls the selected tab into view on each render. - db-tools view: DB Inspector / DB Schema as a .seg.tabs-seg tablist, like Forecast, rendering the chosen view into one tabpanel. The choice is remembered for the session only (dbToolsTab). - DB Inspector: Clarity panel and .tbl table with the Transactions pager. Re-reads the store on every visit, keeping store, search and page (clamped if the store shrank). Store change reads at once; the search filters as you type; Load -> Refresh; Clear -> Clear search. The API key in app_state is shown as hidden and skipped by the search. State moves to one DBInspector object. - DB Schema: one panel titled "Database schema" (was "Database Schema & Inspector"). The SVG takes its colors from .sch-* classes (theme tokens); no hex, rgba(), white, legacy aliases or faded text. 872px wide to fit Settings; labels in the gaps; scrolls in its box on phones. app_state key list and accounts.kind brought up to date. - README tip and Settings line; CLAUDE.md §1, §3, §6, §12, §19 and Last updated; version 1.17.0 in all four places. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
Import log records have had rowsRemoved (leftover duplicate copies removed) since v1.8.1; the diagram didn't list it. Found by comparing the diagram's fields with the keys of real records from samples/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
This was referenced Nov 2, 2026
v1.16.2: Fix Rebuild from your folder clearing everything when the folder has no CSV it can read
#25
Open
This was referenced Nov 2, 2026
…e-tab Merges cleanup-stale-docs-and-dead-code (#38), the top of the fix chain stacked on #21, so #10 can merge last. No rebase. Conflicts: - Versions: 1.17.0 kept in the footer, README, Settings -> General and CLAUDE.md §1. CHANGELOG: 1.17.0, then 1.16.15 ... 1.16.1, then 1.16.0. - CLAUDE.md: "Last updated" is #10's note followed by the chain's history; §3's views-db.js line names both the Database tab and the Changelog view that reads CHANGELOG.md. - views-db.js: #10's rebuilt DB Schema code, with #30's plan link note ({type,id}); the Changelog banner keeps "4. CHANGELOG" with #38's text and code (loadChangelog(), no embedded copy). - views-settings.js: #10's tab-bar comment and version line. - #10's wording about the embedded changelog, which #38 removed, is updated in CLAUDE.md §19 and the 1.17.0 entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
gitluis
changed the base branch from
master
to
cleanup-stale-docs-and-dead-code
November 2, 2026 13:35
Owner
Author
…ettings-database-tab Carries master's v1.10.3-v1.10.5 up the stack: declined answers (#14), literal single "~" (#15) and the Import Logs race fix (#18), with clarity-insights' port of #14 to the rebuilt AI tab. One conflict: CLAUDE.md's "Last updated" line. Kept this branch's line and added the v1.10.3-v1.10.5 history. The CHANGELOG merged cleanly. Versions stay 1.17.0. renderImportLog() keeps #18's guards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
gitluis
pushed a commit
that referenced
this pull request
Nov 2, 2026
…e-status-indicator Brings the Clarity redesign and fix stack (#16-#21, #24-#38, #10) into #23, so its backup status can be rebuilt on the app bar. All seven files #23 touched conflicted (CHANGELOG.md, CLAUDE.md, README.md, index.html, js/core.js, js/views-data.js, js/views-settings.js). Each was resolved by taking the redesign's version: the sidebar #23 built on is gone. The tree now equals settings-database-tab at 477f357. The next commit rebuilds #23's changes on the app bar's sync badge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
…database-tab Brings in the second fix chain (#24-#38 already merged here; now the twelve fixes v1.16.16-v1.16.27). Version stays v1.17.0; CHANGELOG runs 1.17.0, 1.16.27 ... 1.16.0, 1.10.5 ... Conflicts: - CHANGELOG.md: 1.17.0 entry on top of the chain's changelog. - README.md, index.html, js/views-settings.js, CLAUDE.md section 1: v1.17.0. - CLAUDE.md Last updated: #10's note, then the chain's history from v1.16.27. - js/views-db.js: #10's rewritten DB Schema kept; the chain's one change there (ruleCategories in the app_state note, v1.16.25) applied to #10's note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
This was referenced Nov 2, 2026
Open
Open
gitluis
changed the base branch from
cleanup-stale-docs-and-dead-code
to
minor-ui-wording-fixes
November 2, 2026 16:39
gitluis
pushed a commit
that referenced
this pull request
Nov 2, 2026
…s-indicator Brings in the second fix chain through #10. Version stays v1.18.0; CHANGELOG runs 1.18.0, 1.17.0, 1.16.27 ... (merged without conflict). Conflicts (CLAUDE.md only): - Section 14, prompting code: this branch's sync badge line, with the tab name the chain corrected ("Data & reset"). - Last updated: this branch's note, then #10's from v1.17.0 with the chain's history from v1.16.27. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
This was referenced Nov 3, 2026
Open
…ettings-database-tab Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUZo6LRYpLthSp2PRi # Conflicts: # CLAUDE.md # README.md # js/views-settings.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Luis asked for DB Inspector and DB Schema to come back into the UI. Since the sidebar's Database section was removed, they could only be opened with
showView()from DevTools.This replaces the original v1.11.0 version of this PR. That version predates the Clarity redesign (#16 → #17 → #19 → #20 → #21) and was never released. The branch now merges the redesign (
clarity-insights, v1.16.0) and rebuilds the tab on it as v1.17.0:Commits on top of
e56b487:dba70da: merge ofclarity-insights.fc957bf: the rebuild.6b101f6: one schema field (import_log.rowsRemoved) the diagram was missing.59b054b: merge ofcleanup-stale-docs-and-dead-code(v1.16.15: Cleanup — remove unused views-database.js, fix the in-app changelog, update stale wording #38), the top of the fix chain v1.16.1: Fix "Clear transaction edits" wiping every transaction when the browser database is empty #24–v1.16.15: Cleanup — remove unused views-database.js, fix the in-app changelog, update stale wording #38 (v1.16.1–v1.16.15), so this PR can merge last. See Merging the fix chain below.What changed
Kept from the original #10
db-toolsview inviews-db.jsrenders the existingdb-inspectorordb-schemaview. Both still open on their own withshowView(), and so doesshowView('changelog').dbToolsTab), like Forecast's. Nothing is saved.views-db.js, so the tab still registers if that block throws (as in v1.9.4). (The embedded changelog copy itself is gone: v1.16.15: Cleanup — remove unused views-database.js, fix the in-app changelog, update stale wording #38 replaced it, and that is merged in.)Changed for Clarity
.seg.tabs-segtablist like Forecast's Savings / Investments (role="tab",aria-selected, rovingtabindex; arrow keys, Home, End). Onerole="tabpanel"is labelled by the selected sub-tab. v1.17.0: Settings → Database tab (DB Inspector, DB Schema), rebuilt on the Clarity redesign #10 used pill buttons with inline styles..panelwith Store and Search fields (.field,.select,.input), Clear search, Refresh, a "Read-only" pill and the count in a.status-line. The records sit in a.panel.flushwith a.tblin.table-scrolland the Transactions screen's.pager..dv-*classes on theme tokens. The old view used legacy aliases (--teal,--amber,--purple) in inline styles.app_staterow forapiKeysays "Hidden: an API key is saved". The search ignores its value, so typing can't reveal it a character at a time. Before, the inspector printed the key in full. Putting the tab in Settings made that much more visible, and CLAUDE.md §13 says never to expose it.DBInspectorobject, which replaces four globals..paneltitled "Database schema". The old card title, "Database Schema & Inspector", came from when one card held both; the inspector is its own sub-tab now. The legend is a.legendrow in the same panel..sch-*classes inindex.htmlthat read the theme tokens. There are no hex values,rgba(),white, legacy aliases or opacity-faded text left in the script.tx_overridesuses--warn-strong-text:--warn-texton its tinted header reached only 4.4:1.app_statekey list wraps inside its box; before, it ran past the edge.app_statekey list:catRules, notcategoryRules. Addedrecurring,cardDetails,sampleData,lastFolderNameandcsvAutoImportPaused.accounts.kind: now gives the current kinds (bank_checking|credit_card|…).import_log: now listsrowsRemoved.[1.11.0]entry and 1.11.0 strings are gone. There is one new[1.17.0] — 2026-11-02entry. All four places (§17), CLAUDE.md §1 and "Last updated" are updated, and the earlier history is kept.views-db.jsline.Merging the fix chain
The fix chain #24–#38 is merged into this branch with a merge commit (no rebase, nothing force-pushed), so this PR merges last. Conflicts and how they were resolved:
views-db.jsline combines both: the Database tab, and the Changelog view that readsCHANGELOG.md.views-db.js: the banner above the Changelog section keeps this PR's number, "4. CHANGELOG", with v1.16.15: Cleanup — remove unused views-database.js, fix the in-app changelog, update stale wording #38's text and code (loadChangelog(), no embedded copy). The DB Schema code is this PR's rebuild, with v1.16.7: Fix transaction links to budgets, buckets and debts pointing at the wrong item after a delete #30's change applied to it: a transaction's plan link is{type,id}, not{type,idx}.views-settings.js: this PR's tab-bar comment and version line.CHANGELOG.md, and the 1.17.0 entry says the tab's code sits above the Changelog view's.The original "Not changed" notes
js/views-database.jswas unused and not loaded. v1.16.15: Cleanup — remove unused views-database.js, fix the in-app changelog, update stale wording #38 deletes it, and that is merged into this branch.spendingview, which always shows the Category rules panel. Settings → Categories links to it. Both are checked intest-dbtab.js.views-db.jsstopped at v1.4.1. v1.16.15: Cleanup — remove unused views-database.js, fix the in-app changelog, update stale wording #38 (merged in) makes the Changelog view readCHANGELOG.md; the merge updates the CLAUDE.md §19 note that called it a separate cleanup.Not verified
getAll()and the per-keystroke search (debounced 200ms,JSON.stringifyper record) weren't timed.tx_overridesfields, were not all exercised.Automated checks: earlier run, not re-run · 59b054b
Moved unchanged from this PR's "Test results" comment on 2026-11-04; not re-run, so not in the new table format. Originally a description section titled "How it was tested".
Headless Chromium (Playwright) at 1280×900 against
samples/(257 transactions), with the pinned CDN libraries served from npm, on this branch's final commit59b054b(the merge of the fix chain into this branch). Each script ran asNODE_PATH=$(npm root -g) node <script> <repo> <outdir>, from one harness shared by every branch in the stack: the base suites, plus every test added by this PR or by a PR below it (cumulative regression).59b054btest-clarity.js(#10's tab-count edit)test-insights.js(#10's tab-count edits)test-finances.jstest-plan.jsboot.jsrace.jsrenderImportLog(the race #18 fixes on master; not in this stack)test-clear-edits.js(from #24)test-rebuild-folder.js(from #25)test-partial-import.js(from #26)test-json-import.js(from #27)test-new-browser-copy.js(from #28)test-json-export.js(from #29)test-plan-links.js(from #30)test-rule-flags.js(from #31, as updated by #32)test-drawer-flags.js(from #32)test-start-balance.js(from #33, as updated by #34)test-ai-summary-period.js(from #34)test-account-names.js(from #35)test-account-order.js(from #36)test-drawer-focus.js(from #37)test-cleanup.js(from #38)test-dbtab.js(new in this PR)test-insights.js's "General: version line" check reads the version from theindex.htmlfooter, andtest-plan.js's "Budget: Save adds it" accepts a new budget with or without anid, requiring thebud_+ 10 base-36 format once it has one (v1.16.7: Fix transaction links to budgets, buckets and debts pointing at the wrong item after a delete #30 adds ids). Nothing else in the base suites changed.test-clarity.jsandtest-insights.jsrun with this PR's tab-count edits (seven tabs, Database last); their version check reads the footer.test-dbtab.js's CHANGELOG check now requires the entries in order: 1.17.0, 1.16.15 … 1.16.1, 1.16.0. Before the merge it only checked that 1.17.0 came before 1.16.0. Its 390px checks are this PR's own; none were added.Measured before the chain
By the agent that rebuilt the tab, on
6b101f6(before the fix chain was merged in). Its suite-check edits below were for that commit; on this branch thetest-clarity.js/test-insights.jscopies have the same tab-count edits but keep the footer-reading version check.Headless Chromium 153.0.8010.12 with the three
samples/CSVs imported (257 transactions), on6b101f6. CDNs are blocked here, so the harness serves the pinned libraries from npm (marked and DOMPurify match the SRI hashes) and Inter from@fontsource. Run withNODE_PATH=$(npm root -g) node <script> <repo> <outdir>.test-clarity.jstest-finances.jstest-plan.jstest-insights.jstest-dbtab.js(new)boot.jsrace.jsrenderImportLog/importLogsBody(the bug #18 fixes). None from this change.Suite checks changed (in the test copies only, because there is now a seventh tab and a new version):
test-clarity.js, "Settings tabs are plain text": the expected labels end in|Database.test-insights.js, "Settings: six tabs…": renamed "seven tabs (the mockup's six + Database)", and the expected labels end in|Database.test-insights.js, "Settings: arrow keys, Home and End…": the expected path isimport,accounts,db-tools,general,general,db-tools. End and ← from General now land on Database, the last tab.test-insights.js, "General: version line": expects v1.17.0 (was v1.16.0).The loops that visit each Settings tab in
test-clarity.js,test-insights.jsandrace.jsstill list the original six.test-dbtab.jscovers the seventh.test-dbtab.jshas 73 checks:DB.counts().db-inspector,db-schemaandchangelogopen on their own.tabindex; labelled inputs; tablescopeand caption; pageraria-currentand disabled ends.views-db.jssections 1–3.app_state.Screenshots reviewed: both sub-tabs at 1280 light, 1280 dark and 390px. Data & reset was also checked at 390px for the tab-bar change.
Manual QA steps
Setup
git checkout settings-database-tab.index.htmlin Edge.samples/(or Choose CSV files and pick the three sample CSVs). Nothing here writes data, but a copy keeps your real folder out of it.1. The Database tab is there and opens on DB Inspector
Expected:
id.2. Keyboard moves between tabs and sub-tabs
Expected:
3. DB Inspector: store, search, paging
WALMART.Expected:
WALMART: 16 records found (257 total in store), filtered as you type (no button needed).4. The API key is never shown
sk-ant-test-1234567890in the API key field and click Save key.apiKeyrow.sk-ant.Expected:
apiKeyrow's value reads Hidden: an API key is saved, not the key.sk-antfinds 0 records (no match on the key's value).5. DB Inspector reads the store again on each visit
Expected:
6. DB Schema
Expected:
transactions,tx_overrides,accounts,import_log,app_state, and a legend (PK, IDX, Link between stores, Optional field).import_loglistsrowsRemoved;accounts.kindnotesbank_checking|credit_card|…; theapp_statekey list (withcatRules,ruleCategories,sampleData,theme…) wraps inside its box.7. The sub-tab is remembered for the session only
Expected:
8. Regression: the views still open on their own, and the other tabs work
showView('db-inspector'), thenshowView('db-schema'), thenshowView('changelog').Expected:
showViewopens that view full page, with no red errors in Console.Please check before merging
In Edge, in a normal window with your data, not InPrivate:
accounts): it loads right away, and the count matches what Data & reset says for that store.app_state, theapiKeyrow says "Hidden: an API key is saved" (if you have a key saved), and your key appears nowhere on the page.https://claude.ai/code/session_013Z8iBXzUjiQbYziDZ8CZft
Generated by Claude Code