Skip to content

v1.10.7: every PR, drafts included, has step-by-step manual testing - #61

Closed
gitluis wants to merge 2 commits into
masterfrom
docs-pr-testing-steps
Closed

gitluis wants to merge 2 commits into
masterfrom
docs-pr-testing-steps

Conversation

@gitluis

@gitluis gitluis commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

Makes your review habit a written rule: every PR, drafts included, has a ## Manual testing (step by step) section. Until now CLAUDE.md §0 only asked for "how it was tested" (what Claude ran), not steps for you to follow.

What changed

  • CLAUDE.md §0 → What every PR includes: a new bullet. Numbered steps, each one action plus what you should see; start from a known state; main change first, then persistence, then regressions; end with the version check. Optional steps and ones needing a real folder or real Edge/Chrome are marked. Applies to docs-only and CI PRs too. Bugs found while following the steps go in new PRs.
  • CLAUDE.md §0, second commit: bug-fix PRs add a ## How to reproduce the bug section before the testing steps: numbered, from a known state on master or the base branch, ending with what goes wrong. The testing steps then follow the same path and show it fixed.
  • Version v1.10.7 in CHANGELOG, README, index.html, js/views-settings.js and CLAUDE.md §1. v1.10.6 is already taken by both v1.10.6: Content Security Policy + SRI on every CDN script #22 and v1.10.6: Ask before opening or stacking a PR; renumber a taken version when syncing with master #52, so this skips to v1.10.7.

Audit of the open PRs (done with this PR, nothing else changed)

Automated checks: earlier run, not re-run · commit not recorded

Moved unchanged from this PR's "Test results" comment on 2026-11-04; not re-run, so not in the new table format. Originally a description section titled "How it was tested".

Docs and version strings only, no code. Checked that no v1.10.5 is left in the four version spots, and that the CHANGELOG entry renders above 1.10.5.

Manual QA steps
  1. Files changed: CLAUDE.md, CHANGELOG.md, README.md, index.html, js/views-settings.js. The last three only change v1.10.5 → v1.10.7.
  2. CLAUDE.md §0 → "What every PR includes": a fourth bullet, Manual testing steps, says drafts are included. Check it reads the way you want.
  3. Same section, next bullet: Reproduction steps for bug fixes says the section goes before the manual testing steps.
  4. CLAUDE.md §1: Current version says v1.10.7.
  5. CHANGELOG.md: the top entry is ## [1.10.7] — 2026-11-04, with both rules.
  6. Open index.html: the sidebar footer and Settings → General show v1.10.7.
  7. PR v2.0.2: Generic storage names (app_db, app-state.json…) + rename script #58: its description now has a "Manual testing (step by step)" section above "Please check before merging".

Please check before merging


Generated by Claude Code


Generated by Claude Code

gitluis commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner Author

Closed in favor of #65, which adds .github/pull_request_template.md as the PR layout standard. Decision: @gitluis, 2026-11-05, in chat (https://claude.ai/code/session_013Z8iBUZ1y4fG6SBtXbANs4):

I want to stick to the template, so #65 is the way to go, we close PRs contradicting, clashing or opposing to these changes.

Why this one clashes: it makes ## Manual testing (step by step) and ## How to reproduce the bug top-level sections; the template nests them under ## Testing as ### Manual QA steps and ### How to reproduce the bug.

🤖 Generated with Claude Code


Generated by Claude Code

@gitluis gitluis closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant