Skip to content

v1.10.11: PR template; CLAUDE.md owner - #65

Open
gitluis wants to merge 3 commits into
masterfrom
docs-pr-template
Open

gitluis wants to merge 3 commits into
masterfrom
docs-pr-template

Conversation

@gitluis

@gitluis gitluis commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Merge order: #52 → #65 (this PR) (v1.10.6 comes first; both edit CLAUDE.md §0)

Summary

Adds a PR template so every new PR description, drafts included, starts with the agreed layout. CLAUDE.md §0 now points to it, and every "Luis" in CLAUDE.md becomes @gitluis. Docs only; no app code changes beyond the version strings.

Suggested version: v1.10.11

What changed

Files

  • .github/pull_request_template.md (new): Summary → Root cause → What changed (Files, Behavior, Trade-offs, Found, not fixed) → Testing (Automatic checks, Not verified, How to reproduce the bug, Manual QA steps) → Check before merging. Optional merge-order and stacked lines at the top. Guidance is in HTML comments, so it doesn't show in the rendered PR.
  • CLAUDE.md: §0 "What every PR includes" points to the template and summarizes it, including titles in sentence case after the version (v1.11.1: Fix …); "Luis" → @gitluis (3 places, §0 and §14); current version and footer updated.
  • CHANGELOG.md, index.html, README.md, js/views-settings.js: version bump to v1.10.11.

Behavior

No change to the app. On GitHub, opening a new PR pre-fills the description with the template.

Trade-offs

Remaining overlap with #52

Compatible and still open. It edits the same lines (§0 "What every PR includes", §1 version, footer, CHANGELOG top, the four version strings), so #65 needs a sync after it merges. It adds about 5 "Luis" mentions in §0; the sync converts them to @gitluis.

Found, not fixed

Testing

Automated checks

Environment: cloud Linux, Node · Commit: e154f4c · Passed: 6/6

Check Result Notes
Version matches CHANGELOG, index.html, README, views-settings.js and CLAUDE.md, and is next after open PRs (v1.10.10) ✅ Pass
No "Luis" left in CLAUDE.md ✅ Pass 3 replaced
No "Automatic checks" left; section named Automated checks ✅ Pass
Template has no references to another project or bank names ✅ Pass
node --check js/views-settings.js ✅ Pass
Template and §0 state the sentence-case title rule ✅ Pass Open PR titles renamed to match on 2026-11-05

Not verified

  • GitHub pre-filling the template on a new PR (only happens once it's on master).
  • The app wasn't run in a browser; only version strings changed in code.

Manual QA steps

Setup: open this PR's Files changed tab.

  1. Open .github/pull_request_template.md → sections in the order Summary, Root cause, What changed, Testing, Check before merging; no mention of any other project.
  2. Open CLAUDE.md, search "Luis" → no results; search "@gitluis" → 4 results (§0 ×3, §14 ×1).
  3. Read CLAUDE.md §0 "What every PR includes" → it points to the template.
  4. Check the version reads v1.10.11 in CHANGELOG.md, index.html, README.md, js/views-settings.js and CLAUDE.md §1.
  5. After merging: start a new PR on GitHub → the description is pre-filled with the template.

Check before merging

  • Template layout is what you want as the standard for every PR

https://claude.ai/code/session_013Z8iBUZ1y4fG6SBtXbANs4


Generated by Claude Code

- Add .github/pull_request_template.md (pre-fills every new PR description)
- CLAUDE.md §0 "What every PR includes" points to the template
- CLAUDE.md: every "Luis" becomes @gitluis
- Version bumped in CHANGELOG, index.html, README, views-settings.js, CLAUDE.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Z8iBUZ1y4fG6SBtXbANs4
@gitluis gitluis changed the title v1.10.11: PR template; CLAUDE.md names the owner as @gitluis v1.10.11: PR template; CLAUDE.md owner Nov 5, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Z8iBUZ1y4fG6SBtXbANs4
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Z8iBUZ1y4fG6SBtXbANs4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants