Repository navigation
Conversation
- Add .github/pull_request_template.md (pre-fills every new PR description) - CLAUDE.md §0 "What every PR includes" points to the template - CLAUDE.md: every "Luis" becomes @gitluis - Version bumped in CHANGELOG, index.html, README, views-settings.js, CLAUDE.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUZ1y4fG6SBtXbANs4
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUZ1y4fG6SBtXbANs4
This was referenced Nov 5, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBUZ1y4fG6SBtXbANs4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: #52 → #65 (this PR) (v1.10.6 comes first; both edit CLAUDE.md §0)
Summary
Adds a PR template so every new PR description, drafts included, starts with the agreed layout. CLAUDE.md §0 now points to it, and every "Luis" in CLAUDE.md becomes @gitluis. Docs only; no app code changes beyond the version strings.
Suggested version: v1.10.11
What changed
Files
.github/pull_request_template.md(new): Summary → Root cause → What changed (Files, Behavior, Trade-offs, Found, not fixed) → Testing (Automatic checks, Not verified, How to reproduce the bug, Manual QA steps) → Check before merging. Optional merge-order and stacked lines at the top. Guidance is in HTML comments, so it doesn't show in the rendered PR.CLAUDE.md: §0 "What every PR includes" points to the template and summarizes it, including titles in sentence case after the version (v1.11.1: Fix …); "Luis" → @gitluis (3 places, §0 and §14); current version and footer updated.CHANGELOG.md,index.html,README.md,js/views-settings.js: version bump to v1.10.11.Behavior
No change to the app. On GitHub, opening a new PR pre-fills the description with the template.
Trade-offs
<details>layout and PR-comment results proposed in v1.10.7: every PR, drafts included, has step-by-step manual testing #61, v1.10.8: PR layout — steps collapsed, test results in comments #62 and v1.10.10: PR layout — automated checks vs manual QA, results as a table #64, and v1.10.9: PR titles start with the version (vX.Y.Z: title) #63's title rules overlap with it. Those PRs were closed on 2026-11-05 in favor of this one. Rules they had that the template drops: v1.10.7: every PR, drafts included, has step-by-step manual testing #61's footer-version check and marking real-folder-only steps; v1.10.10: PR layout — automated checks vs manual QA, results as a table #64's Area column, fixed "Manual QA passed" box and re-run rules; v1.10.9: PR titles start with the version (vX.Y.Z: title) #63's lowercase-title and no-prefix rules.Remaining overlap with #52
Compatible and still open. It edits the same lines (§0 "What every PR includes", §1 version, footer, CHANGELOG top, the four version strings), so #65 needs a sync after it merges. It adds about 5 "Luis" mentions in §0; the sync converts them to @gitluis.
Found, not fixed
samples/file names still contain bank names on master (fixed by v1.12.0: Remove bank names from the app; neutral account codes with a data migration #16, unmerged). The template's Setup line refers tosamples/generically.Testing
Automated checks
Environment: cloud Linux, Node · Commit:
e154f4c· Passed: 6/6node --check js/views-settings.jsNot verified
Manual QA steps
Setup: open this PR's Files changed tab.
.github/pull_request_template.md→ sections in the order Summary, Root cause, What changed, Testing, Check before merging; no mention of any other project.CLAUDE.md, search "Luis" → no results; search "@gitluis" → 4 results (§0 ×3, §14 ×1).CHANGELOG.md,index.html,README.md,js/views-settings.jsand CLAUDE.md §1.Check before merging
https://claude.ai/code/session_013Z8iBUZ1y4fG6SBtXbANs4
Generated by Claude Code