match listed unsafe names before safe pattern in classify_class_name - #51
Open
abdul-khaliq-khalid wants to merge 1 commit into
Open
match listed unsafe names before safe pattern in classify_class_name#51abdul-khaliq-khalid wants to merge 1 commit into
abdul-khaliq-khalid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
classify_class_name runs the safe regex before the unsafe one, so a name whose module is safe-listed but whose full path is in UNSAFE_STRINGS (pydoc.locate, pydoc.pipepager, torch.load, numpy.lib.npyio.loadtxt, pandas.read_pickle) comes back SAFE, and _reclassify_with_resolution then re-labels an already detected hit as safe. A pickle that invokes one of these gadgets scores unsafe=0 when the referenced module is importable, so pydoc.pipepager runs a shell command yet passes the scan. This checks exact membership in the unsafe, suspicious, then safe sets before the pattern fallback, the same order _classify_item already uses.