Skip to content

match listed unsafe names before safe pattern in classify_class_name #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abdul-khaliq-khalid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

match listed unsafe names before safe pattern in classify_class_name #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,17 @@ def get_optimal_workers(file_size: int) -> int:
@functools.lru_cache(maxsize=None)
def classify_class_name(class_name: str) -> Classification | None:
"""Classifies a class name based on the safe, unsafe, and suspicious patterns."""
# An exact list membership is more specific than a pattern match, so honor it
# first (most dangerous wins). Otherwise a specific unsafe entry like
# "pydoc.pipepager" is masked by the safe pattern for its module ("pydoc"),
# while a specific safe entry like "shutil.disk_usage" still beats the unsafe
# pattern for its module ("shutil"). This matches _classify_item's ordering.
if class_name in constants.UNSAFE_STRINGS:
return Classification.UNSAFE
if class_name in constants.SUSPICIOUS_STRINGS:
return Classification.SUSPICIOUS
if class_name in constants.SAFE_STRINGS:
return Classification.SAFE
if re.search(safe_pattern, class_name):
return Classification.SAFE
if re.search(unsafe_pattern, class_name):
Expand Down