chore: monorepo preparation - #683
Conversation
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
An issue I see here is that if we move these things first, then this will be the last PR we can merge against the sub-repo. Because you're removing all the workflow files, the tests will cease to exist.
You see this as a first, step, but I would say the opposite, this should be the FINAL changes that are made to this repo, if they're made at all. We don't even need to submit a PR to remove these files, since we can just omit them when we move the rest of the code to the monorepo.
Hectorhammett
added
the
do not merge
f1e8520 to
ce64b6c
Compare
c9753cd to
e85a5ab
Compare
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
Looks great! The main thing I noticed is it looks like we did a massive find/replace to import HelperTrait, but it can be removed from quite a few test files. Also a nit, it's not in alphabetical order (our CS used to complain about this, so please make sure it's in alphabetical order with the other use statements).
All my comments are small fixes. Nice work!
|
|
||
| private const SCOPE = ['scope/1', 'scope/2']; | ||
| private const TARGET_AUDIENCE = 'test-target-audience'; | ||
| // phpcs:ignore Generic.Files.LineLength |
There was a problem hiding this comment.
Does this ignore the next line or does it disable the check for the entire file?
There was a problem hiding this comment.
It is for the entire file, I removed it and used string concatenation.
100f174 to
7586d22
Compare
7586d22 to
ac90eac
Compare
2 participants
This PR prepares the auth library to be moved into the google cloud mono repo.