Hide the "Studies using the same instruments" discovery chip - #63
Merged
Merged
Conversation
Discovery's instruments filter needs its own instrument names; Harmony's names (e.g. "SCARED English (child)", "CES_D English") return zero results, so the chip would land users on an empty search. Kept behind a flag so it can come back once the names are mapped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for harmony-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Discover card links to Harmony Discovery with
?instruments=<name>. Discovery only matches its own instrument names, and Harmony's names don't line up with them. For example,SCARED English (child)+CES_D Englishreturn 0 results on harmonydata.ac.uk/search. So the chip sent users to an empty search.This hides the chip behind
SHOW_INSTRUMENTS_CHIP = falseinResults.js. It also keeps the Discover card from showing up empty when topics are empty but instruments aren't. The "Studies with matching topics" chip and the per-match Discovery links are unchanged; both work on the live/searchapp.Tested with a local production build (
CI=true npm run buildandbuild:HarmonyExportboth pass). The Discover card renders with the topics chip only, and every match row carries its Discovery link.🤖 Generated with Claude Code