refactor(series): the ReduceOp equality extension joins the engine seam - #430
Merged
Merged
Conversation
The enum and reducer_for were already #doc(hidden) engine seams, but the Eq extension's promoted equal/not_equal stayed in the series interface — two methods on a type the interface never declares. The extension now carries the same attribute pair as the KeyCell extensions, so the last visible trace of the seam leaves the public interface; the engine packages keep reaching it as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enum and
reducer_forwere already hidden engine seams, but theEqextension's promotedequal/not_equalstayed in the series interface — two methods on a type the interface never declares. The extension now carries the same attribute pair as theKeyCellextensions; the interface, and both snapshots, lose exactly those two lines.