Skip to content

refactor(series): the ReduceOp equality extension joins the engine seam #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ihb2032 merged 1 commit into from
Sep 29, 2026
Merged

refactor(series): the ReduceOp equality extension joins the engine seam #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/scripts/engine_seams.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ io | doc_hidden internal_engine | pub fn write_text( path : String, content : St
series | doc_hidden internal_engine | pub enum SortKey
series | doc_hidden internal_engine | pub extend KeyCell with Eq::{equal, not_equal}
series | doc_hidden internal_engine | pub extend KeyCell with Hash::{hash, hash_combine}
series | doc_hidden internal_engine | pub extend ReduceOp with Eq::{equal, not_equal}
series | doc_hidden internal_engine | pub fn Series::build_sort_key( self : Series, descending : Bool, nulls_last : Bool, ) -> SortKey | used by: frame
series | doc_hidden internal_engine | pub fn Series::coalesce_columns( self : Series, fill : Series, name : String, ) -> Series | used by: frame
series | doc_hidden internal_engine | pub fn Series::empty_of( name : String, dtype : @types.DataType, ) -> Series raise @types.DataError | used by: frame
Expand Down
2 changes: 0 additions & 2 deletions .github/scripts/facade_surface.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,6 @@ method OnParseError::to_repr(Self) -> @debug.Repr <- io
method ParseErrorDetail::equal(Self, Self) -> Bool <- types
method ParseErrorDetail::not_equal(Self, Self) -> Bool <- types
method ParseErrorDetail::to_repr(Self) -> @debug.Repr <- types
method ReduceOp::equal(Self, Self) -> Bool <- series
method ReduceOp::not_equal(Self, Self) -> Bool <- series
method Scalar::as_bool(Self) -> Bool raise DataError <- types
method Scalar::as_float(Self) -> Double raise DataError <- types
method Scalar::as_int(Self) -> Int64 raise DataError <- types
Expand Down
3 changes: 0 additions & 3 deletions series/pkg.generated.mbti
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ pub fn Series::to_repr(Self) -> @debug.Repr
pub fn Series::to_scalars(Self) -> Array[@types.Scalar]
pub fn Series::variance(Self) -> Double raise @types.DataError

pub fn ReduceOp::equal(Self, Self) -> Bool
pub fn ReduceOp::not_equal(Self, Self) -> Bool

// Type aliases

// Traits
6 changes: 6 additions & 0 deletions series/reduce.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,12 @@ pub(all) enum ReduceOp {
} derive(Eq)

///|
/// Equality for the engine packages: the expression AST carries a `ReduceOp`
/// inside its `Agg` node, and the AST's own `Eq` derive reaches this method
/// from another package. The attributes keep the promoted methods out of the
/// public interface, like the enum they belong to.
#doc(hidden)
#internal(engine, "MoonFrame execution engine API")
pub extend ReduceOp with Eq::{equal, not_equal}

///|
Expand Down
Loading