Fix mobile swipe-down input triggering unintended jump - #2
Merged
Merged
Conversation
Co-authored-by: jankln <77668140+jankln@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix player jump issue on mobile version during scroll
Fix mobile swipe-down input triggering unintended jump
Aug 18, 2026
jankln
marked this pull request as ready for review
August 18, 2026 12:48
There was a problem hiding this comment.
Pull request overview
This PR adjusts mobile input handling to prevent a downward swipe (duck) from triggering an unintended jump by separating tap intent from swipe intent and avoiding duplicate touch routing through pointer events.
Changes:
- Pointer event handlers now ignore touch pointers to avoid overlapping pointer + touch input streams.
touchstartno longer triggersjump(), andtouchendtriggersjump()only for tap-like gestures (deltaY <= 40).- Swipe-down duck behavior is preserved while maintaining tap-to-restart on game over.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
528
to
535
| if (state.gameOver && deltaY <= 40) { | ||
| resetGame(); | ||
| startGame(); | ||
| } else if (deltaY <= 40 && (!state.started || state.running)) { | ||
| jump(); | ||
| } else { | ||
| releaseJump(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile touch input was firing
jump()at gesture start, so a downward swipe intended to duck could trigger a jump first. This change separates tap vs swipe intent before applying jump logic.Input routing on mobile
event.pointerType === "touch"), so touch is handled in one path only.Tap-vs-swipe gesture handling
touchstart.touchendnow triggers jump only for tap-like gestures (deltaY <= 40).Representative change