Skip to content

Fix mobile swipe-down input triggering unintended jump #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jankln merged 2 commits into from
Aug 18, 2026
Merged

Fix mobile swipe-down input triggering unintended jump #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8116d3b
Initial plan
Copilot Aug 18, 2026
52cf651
Fix mobile swipe triggering jump
Copilot Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,13 +459,19 @@ function handleKeyUp(event) {
}

function handlePointerDown(event) {
if (event.pointerType === "touch") {
return;
}
pointerStart = { y: event.clientY, time: performance.now() };
if (!state.started || state.running) {
jump();
}
}

function handlePointerMove(event) {
if (event.pointerType === "touch") {
return;
}
if (!pointerStart || !state.running) {
return;
}
Expand All @@ -476,6 +482,9 @@ function handlePointerMove(event) {
}

function handlePointerUp(event) {
if (event.pointerType === "touch") {
return;
}
if (!pointerStart) {
return;
}
Expand All @@ -495,9 +504,6 @@ function handleTouchStart(event) {
}
const touch = event.touches[0];
touchStart = { y: touch.clientY, time: performance.now() };
if (!state.started || state.running) {
jump();
}
event.preventDefault();
}

Expand All @@ -522,8 +528,11 @@ function handleTouchEnd(event) {
if (state.gameOver && deltaY <= 40) {
resetGame();
startGame();
} else if (deltaY <= 40 && (!state.started || state.running)) {
jump();
} else {
releaseJump();
}
Comment on lines 528 to 535
releaseJump();
duck(false);
touchStart = null;
event.preventDefault();
Expand Down