Fail closed when compose ffmpeg times out with a partial mux - #121
Merged
Merged
Conversation
Composer._run_ffmpeg treated TimeoutExpired as success when the output path already existed. A hung mux could leave a truncated recording that compose counted as done. Always raise ComposeError and unlink the incomplete file, matching concat's timeout contract. Co-authored-by: jmjava <jmjava@gmail.com>
ruff, pytest (703 passed, 1 skipped), and docgen benchmark all green. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composer._run_ffmpegtreatedsubprocess.TimeoutExpiredas success when the output path already existed and had a non-zero size. A hung mux could leave a truncatedrecordings/<stem>.mp4; compose printed a warning and counted the segment as composed. Concat already raises on ffmpeg timeout.This PR:
ComposeErroron compose ffmpeg timeout.Milestone:
milestones/compose-ffmpeg-timeout.md. No clock / compile change.Local gates
ruff check src/ tests/— passpytest tests/— 703 passed, 1 skippeddocgen benchmark— meetssrc/docgen/benchmark_data/baseline.json(no--update-baseline)