Honor empty segments.all in yaml-generate - #124
Merged
Merged
Conversation
An explicit all: [] was treated as missing via `all or default`, so discover_visual_map and manim.scenes sync walked default ids even though Config.segments_all is empty. Use all whenever the key is present, including an empty list. Co-authored-by: jmjava <jmjava@gmail.com>
ruff, pytest (713 passed, 1 skipped), and docgen benchmark all green. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config.segments_allhonors an explicit emptysegments.all: [].yaml-generateusedall or default, so an empty list was treated as missing:discover_visual_mapassigned Manim classes todefaultids and rewrotevisual_map.manim.scenessync walkeddefaultinstead of emptyall.--list-gapstreateddefaultids as already inall.This PR uses
segments.allwhenever the key is present (including[]), and falls back todefaultonly whenallis missing or null.Milestone:
milestones/empty-segments-all.md. No clock / compile change.Local gates
ruff check src/ tests/— passpytest tests/— 713 passed, 1 skippeddocgen benchmark— meetssrc/docgen/benchmark_data/baseline.json(no--update-baseline)