Fail closed when wizard JSON bodies are not objects - #129
Merged
Merged
Conversation
POST/PUT handlers used request.json or {} then .get. A JSON array is
truthy, so Flask raised AttributeError. Require an object body and JSON
booleans for with_manim / yaml_generate / llm_scene_spec flags.
Co-authored-by: jmjava <jmjava@gmail.com>
Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #128 typed
POST /api/state. Other wizard POST/PUT handlers still didrequest.json or {}then.get. A JSON array is truthy, so the default never applied and Flask raisedAttributeError.bool(data.get("with_manim", False))treated the string"false"as true.Change
request_json_object(): missing body is{}; list / scalar / null raiseWizardError(400)require_json_bool()forwith_manim,update_requirements,also_manim,yaml_generate,llm_scene_specTests
Local:
ruff check src/ tests/green;pytest tests/745 passed, 1 skipped;docgen benchmarkmeetssrc/docgen/benchmark_data/baseline.json(no--update-baseline)."false"/"true"for bool fields/api/statelist-body test (message now includesnot list)Out of scope
{}viaget_json(silent=True)except Exceptionaroundnarration_topic_label