Move to uv + pyproject.toml#70
Merged
Merged
Conversation
alexjweil
force-pushed
the
push-utmypmyuzzlo
branch
10 times, most recently
from
April 14, 2026 21:02
8636d03 to
45445b3
Compare
alexjweil
force-pushed
the
push-utmypmyuzzlo
branch
from
April 14, 2026 21:03
45445b3 to
eb96fe9
Compare
shreyav
approved these changes
Apr 15, 2026
markatto
added a commit
that referenced
this pull request
Jul 22, 2026
setup.py was deleted in #70 but the release workflow still runs `uv run --frozen python setup.py sdist`, so the next release would fail at the build step. The v2.10.2 release already failed to publish (its workflow run predates #70 and died in the old pipenv setup), which is why PyPI is still at 2.10.1. `uv build` produces the sdist and wheel from pyproject.toml directly, and `gh-action-pypi-publish` picks them up from `dist/` as before. Tested by running `uv build` in this branch: both artifacts build, and the wheel's `lightspark_client.py` compiles with no SyntaxWarning (the E614_REGEX escape fix from #47 is included, which 2.10.1 on PyPI predates).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've migrated to
uv/ruff/tyin basically all our other repos already, so we might as well do so here, too.