fix(cli): avoid executing lint setup when no input is provided - #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167
改动
无输入判断从
parseAsync()之后移到 action 最前面:main()里 parseAsync 之后的原检查删除,保持单一判断来源。行为变化
lint-md(配置正常)lint-md(.lintmdrc损坏)测试(新增 1 个)
getLintConfig未被调用、process.exit(0)被调用——证明 lint setup 完全没有开始既有 "main shows help when no input is provided" 用例不变通过;
--stdin与文件路径的行为由 #166 的用例覆盖。验证
npm test -- --runInBand.lintmdrc+ 裸lint-mdnpm run test:package