Repository navigation
Redesign the page-not-found page as a message box on the 1994 desk - #2346
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| # | Source | Finding | Class | Resolution |
|---|---|---|---|---|
| 1 | edge | auxclick also fires on a right-click (context menu), so the manual buttons counted a pick that never navigated, against the data map |
patch | Fixed in 842809b: counts button === 1 only (MIDDLE_BUTTON), test covers both buttons |
| 2 | blind | Middle-click counted on manual buttons but not on the game, close or taskbar links | patch | Fixed in 842809b: every link counts a middle-click |
| 3 | edge | Tray clock redrew a minute after load, so it could lag the real minute by up to 59s | patch | Fixed in 842809b: msToNextMinute schedules just after each minute turns over, with a test |
| 4 | blind | notFoundReady flag in production code |
dismiss | Same pattern as galleryReady / previewReady, read only by the screenshot runner |
Confirming pass on 842809b: no new patch findings. No defer findings.
Hot-path record (section 6), commit 842809b, whole diff. The only section 1 path touched is src/analytics*.ts (analyticsCore.ts, two names added to the AppActionName type union). src/notFoundPage.ts is its own Vite entry (404.html) and nothing in src/game/, src/render/ or src/ui/ imports it.
| Item | Result | What was checked | Findings and resolution |
|---|---|---|---|
| HP-1 | clear | notFoundPage.ts callers: only 404.html's module script; main() runs once per page load, the clock redraw once a minute. analyticsCore.ts change is type-only, no emitted code |
none |
| HP-2 | n/a | no collection work: the page maps a fixed four-link array | none |
| HP-3 | n/a | one lit render per minute on a page with no game; no per-frame allocation | none |
| HP-4 | n/a | no sorting | none |
| HP-5 | n/a | no maps or sets added | none |
| HP-6 | n/a | no id lookups or removals | none |
| HP-7 | n/a | nothing ported or moved; the old 404 template was replaced, not carried | none |
| HP-8 | n/a | no cache dropped or added; no engine code | none |
| HP-9 | n/a | no HP-2 to HP-6 findings | none |
| HP-10 | n/a | no optimization; the analytics union only grows | none |
| HP-11 | clear | no WASM, host or build-setting change; vite.config.ts untouched (404 entry and precache exclusion unchanged) |
none |
| HP-12 | clear | no game renderer or HUD change; the 404 page's own refresh is one render per minute | none |
Copilot, Codex and PR-Agent are down (out of credits), so an independent stand-in review from another thread is still needed before this signs off.
Generated by Claude Code
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📸 Screenshot drift checkNo drift: the committed screenshots already match a fresh deterministic generation. ✅ |
maniator
left a comment
There was a problem hiding this comment.
Independent stand-in review (Copilot, Codex and PR-Agent are down): stand-in-pr-review + /bmad-code-review, head 842809b
Mode: no-spec. I ran a lean pass with all four layers (Blind Hunter, Edge Case Hunter, Acceptance Auditor against the PR body and the ask, and the Hot-Path Auditor). I also checked the built page in a browser and the routing on both hosts.
What I verified
- Build and links on both hosts. I built with
VC_HELP_ORIGIN=https://help.verticopolis.com, serveddist/in Chromium, and routed requests the wayvercel.jsondoes (on the help host, everything exceptassets/,styles/andapi/goes to/help/..., and a document nobody answers gets the root404.html).help.verticopolis.com/rooms/hotell: the title bar says "Verticopolis Player's Manual" and the heading says "Page 404 isn't in the manual.". The default button is Player's Manual →https://help.verticopolis.com/, then Play the game →https://verticopolis.com/, Release notes →https://help.verticopolis.com/changelog, Every room →https://help.verticopolis.com/rooms.verticopolis.com/towers/old-linkand/helpful: the page is the game's, with Play the game →https://verticopolis.com/as the default and the same manual links.- Every asset loads from both hosts (
/assets/*skips the help rewrite; the favicon and manifest load through/help/). The only misses were Vercel's own/_vercel/*scripts and/api/ingest, which this local setup doesn't serve.
- Vercel routing.
vercel.jsonis unchanged. In production today (4.4.0), bothhelp.verticopolis.com/<missing>andverticopolis.com/<missing>already return the root404.htmlwith a 404 status, so the new page will appear on both hosts. The manual's own Starlight 404 is never served. The PR's preview was still building when I checked. - Something to check after the 4.5.0 deploy (not caused by this PR).
version.jsonstill reports 4.4.0, andhelp.verticopolis.com/changelogand/roomsreturn 404 today, whileverticopolis.com/help/changelogand/help/roomsreturn 200. The manual buttons on this page only work once the #2339 routing is live on production, so check them on the help host after the deploy. - Analytics.
telemetryHostAllowedaccepts*.verticopolis.com, so both hosts send events. The missing address is never sent. The data map and the dashboard tile match the codes in the code. - Tests.
src/notFoundPage.test.tspasses (17 tests). It spies ontrackAppActionand checks real behavior (which site, button order, click and middle-click counting, closing the tab), and its assertions would fail if that behavior broke. No new em-dashes; American English throughout. - CI at 842809b: every completed check is green, including screenshot drift and the
not-foundshard. e2e-general shards 1, 2 and 4 were still running when I posted.
Triage
| # | Source | Finding | Class |
|---|---|---|---|
| 1 | edge+auditor | The built CSS order is reversed: notFound-*.css loads before retro-page-*.css, so body.nf-page (padding 0, 100dvh) loses to body.retro-page. The phone box is 28px narrower than designed, so it isn't full width as the PR body says (inline). |
patch |
| 2 | edge | .btn.xs overrides .nf-win .nf-close for the same reason (inline). |
patch |
| 3 | blind | .changes says app: patch, but the template ticks "New player-facing feature". Pick one: untick it, or say why patch. I agree patch fits a 404 restyle. |
optional |
| 4 | blind | The game screenshots show "There is no page at /404.html", which no player will see. Staging a realistic path, as the manual variant does, would make the gallery shot more representative. |
optional |
| 5 | blind | .nf-task uses repeating-conic-gradient with no fallback background line. Only very old browsers are affected. |
optional |
No defer findings, so no backlog rows.
Hot-path record (section 6), commit 842809b, whole diff
The only section 1 surface touched is src/analyticsCore.ts. I traced the callers myself: the change adds two names to the AppActionName type union and emits no code. src/notFoundPage.ts is only reached from the 404.html entry, and nothing under src/game, src/render or src/ui imports it.
| Item | Result | What was checked | Findings |
|---|---|---|---|
| HP-1 | clear | main() runs once per load; the tray clock redraws once a minute (msToNextMinute), one timer at a time |
none |
| HP-2 | n/a | no collection work beyond mapping the fixed four links | none |
| HP-3 | n/a | one lit render per minute on a page with no game; nothing per frame | none |
| HP-4 | n/a | no sorting | none |
| HP-5 | n/a | no maps or sets | none |
| HP-6 | n/a | no id lookups or removals | none |
| HP-7 | n/a | the old template was replaced, not ported | none |
| HP-8 | n/a | no cache added or dropped | none |
| HP-9 | n/a | no HP-2 to HP-6 findings | none |
| HP-10 | n/a | no optimization claim | none |
| HP-11 | clear | no WASM, host or vite.config.ts change; 404 still kept out of the precache (globIgnores) |
none |
| HP-12 | clear | no game renderer or HUD change | none |
History and version
There are two commits. The second ("Count middle-clicks only, tick the tray clock on the minute, add the shots") is mostly review fixes to the first, so consider folding them when you tidy. The branch is one commit behind main (the 4.5.0 release merge), so rebase before merge. crate: none is correct.
Verdict
NO-GO on 842809b. Fix the stylesheet order (findings 1 and 2), render the four not-found shots again in the pinned container, and push. The rest of the change is sound, so a re-review should be quick.
Reviewed against Verticopolis conventions (.github/copilot-instructions.md).
Generated by Claude Code
maniator
left a comment
There was a problem hiding this comment.
Stand-in re-review (stand-in-pr-review + /bmad-code-review, confirming pass), head 190e222
I read the diff from 842809b first, then the whole diff again.
The earlier findings, checked against the code
| # | Finding at 842809b | Status at 190e222 | Evidence |
|---|---|---|---|
| 1 | body.nf-page lost to body.retro-page in the build |
fixed | I rebuilt with VC_HELP_ORIGIN=https://help.verticopolis.com. dist/404.html now links only notFound-*.css, with the retro rules first. In Chromium the body padding is 0px and the message box is 520px on a computer and 362px on a 390px phone. |
| 2 | .btn.xs overrode .nf-win .nf-close |
fixed | The built close box is padding 0, font-size 11px, line-height 11px, 18px wide |
| 3 (optional) | app: patch vs the "New player-facing feature" box |
addressed | The PR body now says why the box is ticked and the note stays at patch. I agree. |
| 4 (optional) | Shots showed /404.html |
addressed | The game variant now stages /towers/old-link. The committed phone shot shows that path and a full-width box. |
| 5 (optional) | No fallback for repeating-conic-gradient |
addressed | background: var(--r-light) comes first, and the gradient is still applied in Chromium |
Both threads have replies naming 190e222 and are resolved, and the fix is in the code.
Confirming pass
- I ran the host check again:
help.verticopolis.com/rooms/hotellshows the manual version (Player's Manual is the default and goes tohttps://help.verticopolis.com/).verticopolis.com/towers/old-linkand/helpfulshow the game version (Play the game is the default and goes tohttps://verticopolis.com/). Every asset loads on both hosts. src/notFoundPage.test.tspasses (17 tests).- The
@importonly affects this entry. Other pages that useretro-page.cssstill link it themselves. - New
patchfindings: none. Newdeferfindings: none.
Hot-path record (section 6), commit 190e222
This round changed only src/404.html, src/styles/not-found.css, scripts/scenes/notFound.ts and the four screenshots, none of which is a section 1 surface. My record for 842809b (HP-1 to HP-12: clear or n/a, no findings) carries unchanged to 190e222, because the one section 1 file (src/analyticsCore.ts, a type-only union change) is identical.
Verdict
CONDITIONAL GO on 190e222. Conditions:
- CI green on 190e222. When I posted, the test, e2e and screenshot jobs (including the drift check) were still queued or running.
- Before merge, rebase onto
main: the branch is still on d0df552, one commit behind the 4.5.0 release merge. Fold the two fix commits into the first, or give them messages that state the step, as the clean-history rule asks. If the rebased tree matches 190e222 apart from main's changes, this GO carries. If anything else changes, it needs another look.
Reviewed against Verticopolis conventions (.github/copilot-instructions.md).
Generated by Claude Code
The 404 page now matches the game on a computer: a Windows 95 message box on the teal 1994 desk, the startup screen's sunrise skyline across its top with one tower missing floor 404, and a taskbar with the Verticopolis button and a tray clock that turns over on the minute. The same file serves the manual's own host, so the page tells a missing manual page from a missing game page and puts the Player's Manual first there. Every way back to the game still closes a game-opened tab. not-found.css imports retro-page.css and is the page's only stylesheet, so its rules come after the shared ones in the build. Analytics: app_action not_found_view (game or help) and not_found_pick (which button; a click, Enter or middle-click, never a right-click), in the data map and a dashboard tile. The screenshots get their own shard, not-found, rendered in the pinned Playwright container. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ms7trZuFqXAhnhQ4rim5CG
190e222 to
ad21e4b
Compare
|
Condition 2 of the CONDITIONAL GO is done. I folded the three commits into one (ad21e4b). Its tree matched 190e222 exactly before the rebase ( Generated by Claude Code |
Requested by Naftali · project thread
What & why
Naftali asked for a new 404 page that fits the recent updates. The old one was the Windows 3.1 page frame with four big buttons. The new one looks like the game on a computer:
notFoundSite): on the manual's host, or under /help on a build that serves it there, the title says "Verticopolis Player's Manual", the heading says "Page 404 isn't in the manual.", and Player's Manual is the default button.app_actionnot_found_view(gameorhelp) andnot_found_pick(game,manual,changelog,rooms,close,taskbar), a new "Page not found" section indocs/analytics-data-map.mdand a dashboard tile. The missing address is never sent.This PR does not depend on the desk PR (#2336); the page carries its own desk and taskbar styles in
src/styles/not-found.css.Type of change
Game mode impact
n/a: the 404 page runs no game code.
Quality gates
npm run typechecknpm run lintnpm test(648 files, 7,950 tests locally)npm run build(twice in the pinned container for the screenshots; CI too)Versioning
.changesnote with the rightapp:andcrate:levels, or this PR changes no deployed pathpackages/verticopolis-engine/README.mdand/orengine-rs/CRATE_README.md, or read both and putreadmes: unchangedin the note, or this PR changes no engine sourceapp: patch(an existing page restyled, no new game feature),crate: none. The template needs a type box, and a new look for an existing page is closest to "New player-facing feature"; it adds no game feature, so the note stays at patch.Complexity
Hot paths and call frequency (tier), sizes, complexity before and after, remaining scans and why, caches kept or replaced (HP-8), invalidation evidence, measurements: n/a: a standalone page outside the game. It renders once on load and once a minute for the tray clock; the two analytics codes add to a type union only.
Hot-path record (section 6): #2346 (comment) (the only section 1 path is a type-only change to
src/analyticsCore.ts).Screenshots / recordings
Rendered in the pinned Playwright container (
mcr.microsoft.com/playwright:v1.61.1-jammy), newnot-foundshard;screenshot-determinism-check.ts not-foundrendered the four shots identically twice.The old page had no committed screenshot: it was the Windows 3.1 page frame with the heading "Page not found" and four large buttons in a two by two grid.
Notes for reviewers
src/notFoundPage.test.tscovers which site a path belongs to, the button order on each, the tray clock and its minute timer, each pick's analytics code (a spy) for a click and a middle-click (never a right-click), and the close-the-tab path on each way back to the game./bmad-code-reviewround 1 found three patches, fixed in 842809b. The stand-in review at 842809b found the build loading the 404 sheet before the retro sheet (two rules lost); fixed in 190e222 by importing retro-page.css from not-found.css, with the shots rendered again. Its optional notes are in too: a real missing path in the game shots, and a plain face behind the taskbar task's checker.notFoundReady. The manual's variant is staged with404.html?at=manual, which moves the address under /help before the page reads it..page-linksand.page-lede codeleftretro-page.csswith their only user.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ms7trZuFqXAhnhQ4rim5CG