Repository navigation
fix(metadata): resolve bare root-level @objectRef in Java loader - #525
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #522
Closes #523
What changed
metadata.root(for example an abstractfield.objecttemplate that other fieldsextends) now resolves a bare@objectRefin its own package, as ADR-0042 specifies and TypeScript already did. A real miss still fails withERR_UNRESOLVED_OBJECT_REF, and the message no longer names the loader as the owner of a root-level node. The change is inRegisteredValidation.walk.root-level-field-object-bare-ref(must load in every port) anderror-root-level-field-objectref-unresolved(must fail in every port). TypeScript, Java, C# and Python pass both; Kotlin consumes the Java metadata. Before the fix the first fixture failed in Java only. Fixture count 421 to 423 indocs/CONFORMANCE.mdandAGENTS.md;examples/showcase/site-payload.jsonrefreshed for the count.docs/RELEASING.mdnow lists a new attribute as PATCH in both the pre-1.0 and post-1.0 columns, matching "The vocabulary rule". One stale phrase indocs/1.0-readiness.mdthat named a new vocab member as a MINOR trigger now says "a new top-level type". Other rows are unchanged; ADR-0035, the releasing skill and the release scripts already said PATCH.CHANGELOG.md:[Unreleased]entry for the Java fix. No version files touched.Testing
ConformanceTest(838) green with the fix; the new fixture fails on the base code.metadatamodule: 2992 tests, 0 failures. TypeScript conformance, C# conformance (2202) and Python conformance (1680) green.scripts/ci-local.sh --quickgreen after the site payload refresh.Gate
no-mistakes gate: 1 run, no findings at any step.