Repository navigation
fix(metadata): exempt read-only @sql views from column-name collision check - #528
Merged
Merged
Conversation
…jects; gate wording
…her docs already current
dmealing
added a commit
that referenced
this pull request
Nov 4, 2026
Brings in #528 (read-only @SQL view column-collision exemption) and #530 (cross-field validators in generated create models). Conflicts resolved by keeping both sides: the conformance fixture count is 428 (main's 426 plus this branch's two provider-custom-vocabulary fixtures) in AGENTS.md, docs/CONFORMANCE.md and the site payload, and CHANGELOG keeps both entries. The metaobjects-authoring SKILL.md is held under its 500-line cap: the provider section's per-language wiring table moves into the per-language provider references it already pointed at, with a one-line pointer left in place, and the agent-context conformance fixtures are regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
ERR_COLUMN_NAME_COLLISIONskips an object whose sources are all read-only and include asource.rdb @kind: viewwith an@sqlbody. Two fields may read one column in such a view. The same exemption is applied in the TypeScript, Java, C# and Python validation passes.@sql) and objects with a writable source are still checked.@column, the error message now says to rename one field or point one@columnat a different column. The error code is unchanged.column-name-shared-in-sql-view-ok,error-column-name-collision-derived-viewanderror-column-name-collision-table-with-sql-view, plus a per-port regression test (TypeScript, Java, C#, Python).ERROR-CODES.jsonanddocs/CONFORMANCE.mdare updated to match, and the CHANGELOGFixedentry is added.Validation
Risk Assessment
✅ Low: Narrow, symmetric exemption in all four ports (every source read-only and at least one
@sqlview), backed by shared conformance fixtures and per-port message tests. It matches the intent and the recorded decisions, and no wrong-result path turned up.Testing
The Test agent exceeded its invocation budget before live validation completed; no evidence was gathered for this head.
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.