[HLSL] Add LinAlg element boundary coverage#8668
Draft
JoeCitizen wants to merge 9 commits into
Draft
Conversation
Use the shared MatrixUse parameter for the OuterProduct result and set it to Accumulator, matching proposal 0035 and the public dx::linalg API. Add a host-side invariant to prevent the legacy A-use declaration from returning. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
Create SRV buffers without UAV flags and transition them for both pixel and non-pixel shader access. Use a direct resource-initialization list so the graphics-only pixel state is legal. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
Add typed F16, F32, I32, and U32 matrix data with safe byte encoding, rectangular row/column-major storage mapping, and explicit exact, permitted-result, or excluded comparison policy. Cover offsets and padded strides with independent host goldens, and migrate the existing CopyConvert tests onto the oracle. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
This was referenced Jul 24, 2026
Handle packed row or column byte-count overflow before using the result, and include raw F32 bits in exact mismatch diagnostics. Cover adjacent float bit patterns in the host oracle test. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
Add ABI-checked wrappers for the six D3D12 Linear Algebra capability query categories and explicit applicability classification. Gate the rectangular F32 CopyConvert case using concrete supported wave sizes. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
Compile capability-gated CopyConvert coverage at the exact wave size whose MatrixConstruction support was queried. Keep mandatory baseline cases on the existing ranged WaveSize attribute. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
JoeCitizen
force-pushed
the
linalg-hlk-element-access-boundaries
branch
from
July 25, 2026 01:03
bf8b650 to
786820c
Compare
added 2 commits
July 25, 2026 14:10
Validate multiplication support flags per operation, exhaustively check the preview D3D12 ABI mirrors, and preserve query-backed optional skips in HLK mode. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
Add rectangular Length/GetCoordinate/GetElement coverage and the specified Get/Set out-of-bounds behaviour. Capture thread-local matrix records without UAV races and gate optional F32 cases at the exact queried wave size. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
JoeCitizen
force-pushed
the
linalg-hlk-element-access-boundaries
branch
from
July 25, 2026 02:27
786820c to
2dc4344
Compare
Seed OOB Get outputs with non-zero sentinels and require every lane in the selected wave to execute and write the specified zero result. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Length,GetCoordinate, andGetElementrecords, avoiding UAV races when multiple threads map to one componentGet(Length())returns zero andSet(Length(), value)leaves the matrix unchangedWaveSizeExpected matrix values come from the typed CPU oracle. The host validates every reported coordinate/value pair, requires the summed thread-local lengths to cover the matrix, verifies exact unchanged-matrix results for Set OOB, and prevents untouched zero-initialized UAV data from satisfying Get OOB.
Validation
ExecHLSLTeststargetElementAccess_Wave_16x16_F16andElementSet_Wave_16x16_F16methodsElementAccess_Wave_4x8_F32,ElementGetOOB_Wave_4x8_F32, andElementSetOOB_Wave_4x8_F32on WARP with D3D12 Agility SDK1.721.2-previewandExperimentalShaders=*FORCED_WAVE_SIZE=4; the corrected Get OOB test observed exactly four executing lanesgit diff --check, and focused correctness review passNo physical GPU or HLK lab execution is claimed.
Stack
This draft is stacked on PR #8667, which is stacked on PR #8666, PR #8665, and PR #8662. Until those ancestors land, this diff contains their commits as well. The element-boundary commits are
2dc434497and review correction49a726cd0.This is intentionally a draft for named human review. The reviewer should reproduce the OOB rules from proposal 0035, inspect the per-thread record and sentinel oracles, and confirm the capability-gated exact-wave policy before requesting maintainer review.
Refs #7841
Refs #8648
Refs #8549
Refs #8550
Refs #8551
Refs #8552
Assisted-by: GitHub Copilot