Cache duration Pattern in GenerationalHeapParser CMS remark path - #579
Open
Hashim Khan (Hashim1999164) wants to merge 2 commits into
Open
Cache duration Pattern in GenerationalHeapParser CMS remark path#579Hashim Khan (Hashim1999164) wants to merge 2 commits into
Hashim Khan (Hashim1999164) wants to merge 2 commits into
Conversation
Compile DURATION_GROUP_PATTERN once as a static final field instead of on every CMS remark weak-reference split parse call. Fixes microsoft#567.
Replace greedy .* with a line bounded prefix so matcher.find still selects the last pause time. Guard null parse results that SonarCloud flags as reliability bugs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
splitRemarkReferenceWithWeakReferenceSplitBugrecompiledPattern.compile(".* " + PAUSE_TIME)on every call. That matches other parser patterns that already usestatic finalcompiled patterns.This change introduces
DURATION_GROUP_PATTERNand reuses it for matching.Fixes #567
Test plan
./mvnw -pl parser -am -DskipTests compile