Skip to content

Cache duration Pattern in GenerationalHeapParser CMS remark path #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hashim Khan (Hashim1999164) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cache duration Pattern in GenerationalHeapParser CMS remark path #579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ecdc9
Cache duration Pattern in GenerationalHeapParser
Hashim1999164 Aug 12, 2026
746dc23
Tighten pause duration regex to avoid ReDoS
Hashim1999164 Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions parser/src/main/java/com/microsoft/gctoolkit/parser/GenerationalHeapParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@

private static final Logger LOGGER = Logger.getLogger(GenerationalHeapParser.class.getName());

// Cached for the CMS remark/weak-reference split-bug path; avoid recompiling on every parse call.
// [^\n]* preserves last-match semantics of greedy .* without a ReDoS hotspot.
private static final Pattern DURATION_GROUP_PATTERN = Pattern.compile("[^\\n]* " + PAUSE_TIME);

private ParNew parNewForwardReference;
private GarbageCollectionTypes garbageCollectionTypeForwardReference;
private GCCause gcCauseForwardReference;
Expand Down Expand Up @@ -626,9 +630,11 @@
gcCauseForwardReference = GCCause.PROMOTION_FAILED;
ArrayList<Integer> blocks = new ArrayList<>();
GCLogTrace block = PARNEW_PROMOTION_FAILURE_SIZE_BLOCK.parse(line);
do {
blocks.add(block.getIntegerGroup(1));
} while (block.hasNext());
if (block != null) {
do {
blocks.add(block.getIntegerGroup(1));
} while (block.hasNext());
}
promotionFailureSizesForwardReference = new int[blocks.size()];
for (int index = 0; index < blocks.size(); index++)
promotionFailureSizesForwardReference[index] = blocks.get(index);
Expand Down Expand Up @@ -1817,7 +1823,8 @@
private void precleanTimedoutWithCards(GCLogTrace trace, String line) {
abortPrecleanDueToTime = true;
GCLogTrace concurrentPhase = new GCParseRule("X",CMS_PHASE_END).parse(line);
endOfConcurrentPhase(concurrentPhase, concurrentPhase.getDateTimeStamp(), 0);
if (concurrentPhase != null)
endOfConcurrentPhase(concurrentPhase, concurrentPhase.getDateTimeStamp(), 0);
}

private void shouldCollectConcurrent(GCLogTrace trace, String line) {
Expand Down Expand Up @@ -1917,8 +1924,7 @@
*/
public void splitRemarkReferenceWithWeakReferenceSplitBug(GCLogTrace trace, String line) {
GCLogTrace remarkTrace = REMARK_CLAUSE.parse(line);
Pattern durationGroupPattern = Pattern.compile(".* " + PAUSE_TIME);
Matcher matcher = durationGroupPattern.matcher(line);
Matcher matcher = DURATION_GROUP_PATTERN.matcher(line);
double duration = 0.0d;
if (matcher.find()) {
duration = Double.parseDouble(matcher.group(matcher.groupCount()));
Expand Down Expand Up @@ -2067,6 +2073,10 @@

private void endConcurrentPrecleanWithReferenceProcessing(GCLogTrace trace, String line) {
GCLogTrace concurrentBlock = CONCURRENT_PHASE_END_BLOCK.parse(line);
if (concurrentBlock == null) {
LOGGER.warning("Unable to extract data from " + trace.toString());

Check warning on line 2077 in parser/src/main/java/com/microsoft/gctoolkit/parser/GenerationalHeapParser.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. Use the built-in formatting to construct this argument. 


See more on https://sonarcloud.io/project/issues?id=microsoft_gctoolkit&issues=AZ_4Xh1axILwZHPZ6Zds&open=AZ_4Xh1axILwZHPZ6Zds&pullRequest=579
return;
}
try {
publish(new ConcurrentPreClean(startOfConcurrentPhase, concurrentBlock.getDoubleGroup(11), concurrentBlock.getDoubleGroup(7), concurrentBlock.getDoubleGroup(8)));
} catch (Throwable t) {
Expand Down
Loading