You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change amends the system_settings field of ProcessContainerUi in the 1.1.0 dev contract to be a string_enum, rather than a String. Values other than 'none', 'parameters', 'display' or 'all' will be rejected. For the stable contracts, there is no change, unrecognized values will be treated as if the value was 'none'.
Details
In the 1.1.0 dev contract, add a string_enum!, ProcessContainerUiSystemSettings.
Amend the type of the system_settings field of the 1.1.0 ProcessContainerUi struct from OptionalField to
OptionalField.
In the normalization layer, add an enum for UiSystemSettings and update the type of the system_settings field of BaseProcessUi from Option to Option.
Update the contract adapter for 1.1.0 to handle ProcessContainerUiSystemSettings when adapting to UiSystemSettings.
Update the contract adapters for 0.9.0 and 1.0.0 to map from String to UiSystemSettings.
Various test updates
Tests
Existing tests pass.
Added tests for rejecting unknown ProcessContainerUi system_settings values in the 1.1.0 dev contract.
This change amends the system_settings field of ProcessContainerUi in the 1.1.0
dev contract to be a string_enum, rather than a String. Values other than
'none', 'parameters', 'display' or 'all' will be rejected. For the stable
contracts, there is no change, unrecognized values will be treated as if the
value was 'none'.
Details
- In the 1.1.0 dev contract, add a string_enum!,
ProcessContainerUiSystemSettings.
- Amend the type of the system_settings field of the 1.1.0 ProcessContainerUi
struct from OptionalField<String> to
OptionalField<ProcessContainerUiSystemSettings>.
- In the normalization layer, add an enum for UiSystemSettings and update the
type of the system_settings field of BaseProcessUi from Option<String> to
Option<UiSystemSettings>.
- Update the contract adapter for 1.1.0 to handle ProcessContainerUiSystemSettings when
adapting to UiSystemSettings.
- Update the contract adapters for 0.9.0 and 1.0.0 to map from String to
UiSystemSettings.
- Various test updates
Tests
- Existing tests pass.
- Added tests for rejecting unknown ProcessContainerUi system_settings values
in the 1.1.0 dev contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change amends the system_settings field of ProcessContainerUi in the 1.1.0 dev contract to be a string_enum, rather than a String. Values other than 'none', 'parameters', 'display' or 'all' will be rejected. For the stable contracts, there is no change, unrecognized values will be treated as if the value was 'none'.
Details
OptionalField.
Tests
Microsoft Reviewers: Open in CodeFlow