Skip to content

test(core): improve codec tests and builder coverage #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mroczect wants to merge 6 commits into from
Closed

test(core): improve codec tests and builder coverage #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0873139
test(core): add comprehensive tests and cleanup
mroczect Aug 20, 2026
48deeff
test(core): add roundtrip tests and cleanup
mroczect Aug 20, 2026
ea1424c
test(core): improve commit builder tests and use numeric separators
mroczect Aug 20, 2026
5cce364
test(core): improve tag builder tests and use numeric separators
mroczect Aug 20, 2026
ee3d838
test(core): add builder API integration tests
mroczect Aug 20, 2026
7f555cb
test(core): add common test utilities
mroczect Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 14 additions & 26 deletions libvctrl_core/src/codec/binary_decoder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,8 +402,6 @@ mod tests {
vec![fill; HASH_LENGTH]
}

// --- Private helper tests ---

#[test]
fn test_check_version_missing_byte() {
let result = BinaryDecoder::check_version(&[]);
Expand Down Expand Up @@ -509,8 +507,6 @@ mod tests {
);
}

// --- decode_blob tests ---

#[test]
fn test_decode_blob_valid() {
let payload = b"hello world";
Expand Down Expand Up @@ -574,8 +570,6 @@ mod tests {
assert!(result.is_err());
}

// --- decode_tree tests ---

#[test]
fn test_decode_tree_valid_single_entry() {
let hb = hash_bytes(0xAB);
Expand All @@ -584,7 +578,7 @@ mod tests {
data.extend_from_slice(&1u32.to_le_bytes());
data.push(4);
data.extend_from_slice(b"file");
data.push(0); // Blob
data.push(0);
data.extend_from_slice(&hb);

let result = BinaryDecoder.decode_tree(Cursor::new(data));
Expand Down Expand Up @@ -613,15 +607,13 @@ mod tests {
let mut data = Vec::new();
data.push(EXPECTED_VERSION);
data.extend_from_slice(&2u32.to_le_bytes());
// Entry 1
data.push(3);
data.extend_from_slice(b"src");
data.push(3); // Tree
data.push(3);
data.extend_from_slice(&hb1);
// Entry 2
data.push(9);
data.extend_from_slice(b"Cargo.toml");
data.push(0); // Blob
data.push(0);
data.extend_from_slice(&hb2);

let result = BinaryDecoder.decode_tree(Cursor::new(data));
Expand All @@ -642,7 +634,7 @@ mod tests {
data.extend_from_slice(&1u32.to_le_bytes());
data.push(1);
data.push(b'x');
data.push(99); // unknown kind
data.push(99);
data.extend_from_slice(&hb);

let result = BinaryDecoder.decode_tree(Cursor::new(data));
Expand All @@ -659,15 +651,15 @@ mod tests {
data.push(b'x');
data.push(0);
data.extend_from_slice(&hb);
data.push(0xFF); // trailing
data.push(0xFF);

let result = BinaryDecoder.decode_tree(Cursor::new(data));
assert!(result.is_err());
}

#[test]
fn test_decode_tree_all_known_kinds() {
let kinds = [0u8, 1, 2, 3, 4]; // Blob, Executable, Symlink, Tree, Submodule
let kinds = [0u8, 1, 2, 3, 4];
let mut data = Vec::new();
data.push(EXPECTED_VERSION);
data.extend_from_slice(&(kinds.len() as u32).to_le_bytes());
Expand All @@ -683,8 +675,6 @@ mod tests {
assert!(result.is_ok(), "should decode all known entry kinds");
}

// --- decode_commit tests ---

fn build_valid_commit_bytes(
tree_fill: u8,
parents: &[u8],
Expand Down Expand Up @@ -736,7 +726,7 @@ mod tests {
"Bob",
"b@c.d",
"init",
1700000000,
1_700_000_000,
0,
None,
);
Expand All @@ -749,7 +739,7 @@ mod tests {
assert_eq!(commit.committer().name(), "Bob");
assert_eq!(commit.committer().email(), "b@c.d");
assert_eq!(commit.message(), "init");
assert_eq!(commit.meta().timestamp(), 1700000000);
assert_eq!(commit.meta().timestamp(), 1_700_000_000);
assert_eq!(commit.meta().timezone_offset(), 0);
assert!(commit.meta().encoding().is_none());
}
Expand All @@ -764,7 +754,7 @@ mod tests {
"Bob",
"bob@ex.com",
"merge",
1700000000,
1_700_000_000,
3600,
Some("UTF-8"),
);
Expand Down Expand Up @@ -804,8 +794,6 @@ mod tests {
assert_eq!(result.unwrap().message(), "");
}

// --- decode_tag tests ---

fn build_valid_tag_bytes(
name: &str,
target_fill: u8,
Expand Down Expand Up @@ -851,7 +839,7 @@ mod tests {
0x10,
Some(("Alice", "alice@ex.com")),
"release",
1700000000,
1_700_000_000,
0,
None,
);
Expand All @@ -867,7 +855,7 @@ mod tests {

#[test]
fn test_decode_tag_no_tagger() {
let data = build_valid_tag_bytes("v2.0", 0x20, None, "", 1700000000, 0, None);
let data = build_valid_tag_bytes("v2.0", 0x20, None, "", 1_700_000_000, 0, None);
let result = BinaryDecoder.decode_tag(Cursor::new(data));
assert!(result.is_ok());
let tag = result.unwrap();
Expand All @@ -883,7 +871,7 @@ mod tests {
0x30,
Some(("Bob", "bob@ex.com")),
"annotated",
1700000000,
1_700_000_000,
-3600,
Some("UTF-8"),
);
Expand All @@ -897,9 +885,9 @@ mod tests {
#[test]
fn test_decode_tag_invalid_tagger_presence() {
let data = build_valid_tag_bytes("v4.0", 0x40, None, "", 0, 0, None);
let pos = 1 + 4 + HASH_LENGTH; // after name + target
let pos = 1 + 4 + HASH_LENGTH;
let mut mutable_data = data;
mutable_data[pos] = 5; // invalid tagger presence byte
mutable_data[pos] = 5;
let result = BinaryDecoder.decode_tag(Cursor::new(mutable_data));
assert!(result.is_err());
}
Expand Down
Loading